From: Manivannan Sadhasivam <mani@kernel.org>
To: Slark Xiao <slark_xiao@163.com>
Cc: hemantk@codeaurora.org, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH net v2] For default mechanism, product would use default MRU 3500 if they didn't define it. But for Foxconn SDX55, there is a known issue which MRU 3500 would lead to data connection lost. So we align it with Qualcomm default MRU settings.
Date: Mon, 17 Jan 2022 21:37:05 +0530 [thread overview]
Message-ID: <20220117160705.GC4209@thinkpad> (raw)
In-Reply-To: <50e92997.386b.17e6775c20b.Coremail.slark_xiao@163.com>
On Mon, Jan 17, 2022 at 05:54:37PM +0800, Slark Xiao wrote:
>
>
>
>
>
>
> At 2022-01-17 16:44:32, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
> >On Mon, Jan 17, 2022 at 04:16:44PM +0800, Slark Xiao wrote:
> >> Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interface MRU")
> >
> >You have messed up the patch subject, please fix it. Also, the correct fixes tag
> >should be the one added the Foxconn modem support, precisely "aac426562f56".
> >
> Yes, sorry for this mistake.
> >One more thing, please make sure this MRU value works well for other Foxconn
> >modems supported by this config.
> >
> I am sure this would work for all our device. BTW, I want to add this mru_default to
> cinterion-mv31 PRODUCT. Shall I use v3 or create a new version for that? It's confirmed
> that this change could help fix issue on that product.
Please submit individual patches with Fixes tag each.
> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> >
> >You should have added my Reviewed-by tag too...
> Shall I add reviewd-by tag if I add changes on MV31 product?
> >
No, only to this patch since I haven't reviewed the MV31 patch.
Thanks,
Mani
> >Thanks,
> >Mani
> >
> >>
> >> ---
> >> v2: Add Fixes tag
> >> ---
> >> drivers/bus/mhi/pci_generic.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> >> index 3a258a677df8..74e8fc342cfd 100644
> >> --- a/drivers/bus/mhi/pci_generic.c
> >> +++ b/drivers/bus/mhi/pci_generic.c
> >> @@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
> >> .config = &modem_foxconn_sdx55_config,
> >> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> >> .dma_data_width = 32,
> >> + .mru_default = 32768,
> >> .sideband_wake = false,
> >> };
> >>
> >> --
> >> 2.25.1
> >>
prev parent reply other threads:[~2022-01-17 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 8:16 [PATCH net v2] For default mechanism, product would use default MRU 3500 if they didn't define it. But for Foxconn SDX55, there is a known issue which MRU 3500 would lead to data connection lost. So we align it with Qualcomm default MRU settings Slark Xiao
2022-01-17 8:44 ` Manivannan Sadhasivam
2022-01-17 9:54 ` Slark Xiao
2022-01-17 16:07 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117160705.GC4209@thinkpad \
--to=mani@kernel.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhi@lists.linux.dev \
--cc=slark_xiao@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).