From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C74D7C43217 for ; Tue, 18 Jan 2022 02:47:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349253AbiARCr4 (ORCPT ); Mon, 17 Jan 2022 21:47:56 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:48990 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344041AbiARCeI (ORCPT ); Mon, 17 Jan 2022 21:34:08 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30EB861269; Tue, 18 Jan 2022 02:34:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8DBEC36AEB; Tue, 18 Jan 2022 02:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642473247; bh=TzeY5kjwuR+907nvx0UXsopJcumuIJtfZTdJBviSCmQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eeg6fZiFsOjrb+AS9MdkUwWbTb4F5XrucoLuVS6C6HJhiHBO78zoEiLzcVyl8QTt/ lh8ArUpYLIFRhHz8Exxne8miMrFJdQUnWvpvFxd++tOWnxtuWzu1uWo2yrg28IGlKH cH8FoALIG4Uo5zrHGePFojUK+HlclYgoQ7PMJLbY2SOkwzRQsh0RhoXLUk0Pe3yrWQ /OoyOLY5b7XwHSnjo5Tm8IncxTNHduGyqw8GHJ13E1CSRPwvzlstPkXwlKDOtRh4M2 XKFF84hlmMKyon2NVE7yDL7fiApdtKPNtGeC8z4vNkX5WMhRHygsJ1DiYRWGEwXZyq q0LN+/Yj9ddVw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jakub Kicinski , "David S . Miller" , Sasha Levin , u.kleine-koenig@pengutronix.de, sudipm.mukherjee@gmail.com, jirislaby@kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 039/188] lasi_82594: use eth_hw_addr_set() Date: Mon, 17 Jan 2022 21:29:23 -0500 Message-Id: <20220118023152.1948105-39-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118023152.1948105-1-sashal@kernel.org> References: <20220118023152.1948105-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski [ Upstream commit 5b6d5affd27486ec9152a66df1741cf67782712a ] dev_addr is set from IO reads, passed to an arch-specific helper. Note that the helper never reads it so uninitialized temp is fine. Fixes build on parisc. Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/i825xx/lasi_82596.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/i825xx/lasi_82596.c b/drivers/net/ethernet/i825xx/lasi_82596.c index 48e001881c75f..0af70094aba34 100644 --- a/drivers/net/ethernet/i825xx/lasi_82596.c +++ b/drivers/net/ethernet/i825xx/lasi_82596.c @@ -147,6 +147,7 @@ lan_init_chip(struct parisc_device *dev) struct net_device *netdevice; struct i596_private *lp; int retval = -ENOMEM; + u8 addr[ETH_ALEN]; int i; if (!dev->irq) { @@ -167,13 +168,14 @@ lan_init_chip(struct parisc_device *dev) netdevice->base_addr = dev->hpa.start; netdevice->irq = dev->irq; - if (pdc_lan_station_id(netdevice->dev_addr, netdevice->base_addr)) { + if (pdc_lan_station_id(addr, netdevice->base_addr)) { for (i = 0; i < 6; i++) { - netdevice->dev_addr[i] = gsc_readb(LAN_PROM_ADDR + i); + addr[i] = gsc_readb(LAN_PROM_ADDR + i); } printk(KERN_INFO "%s: MAC of HP700 LAN read from EEPROM\n", __FILE__); } + eth_hw_addr_set(netdevice, addr); lp = netdev_priv(netdevice); lp->options = dev->id.sversion == 0x72 ? OPT_SWAP_PORT : 0; -- 2.34.1