From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3093CC433EF for ; Tue, 18 Jan 2022 09:26:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245156AbiARJ0R (ORCPT ); Tue, 18 Jan 2022 04:26:17 -0500 Received: from mga17.intel.com ([192.55.52.151]:64332 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234638AbiARJ0Q (ORCPT ); Tue, 18 Jan 2022 04:26:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642497976; x=1674033976; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ripv7PKf8AE+DZencjgRj4jyC+vbpn4HOU9gpa3R3nI=; b=N6L8sQ5GOJhf+6lBVyMCtBMVZCYom3YibpEoo3im5j6pnMtxqQs068Sx FZ0tT/tsKfaKTtvnUKoacwGCSN04ay3JU4DO8AfMD/nw6sn04dxDIsePU BlXatHnvVZpDRhuHZB23lK/rdGJju4ienoaJHgUPB5CR4r3tct15zDKDR Q7geReaWrx56jKw+GZxWs0KYPm++A0fKyf0G1B4bV0xA1mR0E55was4zZ ClljJnCIg1Pi7eRjg19fYJjwZYPzCAEVrT3WBZ7jQvRxfnuHtgXZ+jFAC MA7TGe7+uKjaIdWIyJaas8Dmc4zkEo5q4Dkbqp1XvV5iCnlfTgBlyXEco Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="225452482" X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="225452482" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 01:26:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="578339881" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 18 Jan 2022 01:26:09 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1n9kkj-000CPD-AO; Tue, 18 Jan 2022 09:26:09 +0000 Date: Tue, 18 Jan 2022 17:25:31 +0800 From: kernel test robot To: Hannes Reinecke Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Chaitanya Kulkarni , Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: [PATCH] nvme-fabrics: fix returnvar.cocci warnings Message-ID: <20220118092531.GA25410@95126676e75f> References: <202201181710.TjfwKXN9-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202201181710.TjfwKXN9-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") CC: Hannes Reinecke Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e3a8b6a1e70c37702054ae3c7c07ed828435d8ee commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics :::::: branch date: 5 hours ago :::::: commit date: 4 weeks ago fabrics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str static int nvmf_dev_show(struct seq_file *seq_file, void *private) { struct nvme_ctrl *ctrl; - int ret = 0; mutex_lock(&nvmf_dev_mutex); ctrl = seq_file->private; @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file out_unlock: mutex_unlock(&nvmf_dev_mutex); - return ret; + return 0; } static int nvmf_dev_open(struct inode *inode, struct file *file)