Re: [PATCH] net: mscc: ocelot: fix using match before it is set

Vladimir Oltean
2022-01-20T17:08:59Z

On Tue, Jan 18, 2022 at 05:41:10AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Clang static analysis reports this issue
> ocelot_flower.c:563:8: warning: 1st function call argument
> is an uninitialized value
> !is_zero_ether_addr(match.mask->dst)) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The variable match is used before it is set. So move the
> block.
>
> Fixes: 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

(sorry for the delay)