Re: [PATCH v5 8/9] ALSA: hda/realtek: Add support for HP Laptops

Takashi Iwai
2022-01-21T14:44:06Z

On Fri, 21 Jan 2022 15:32:53 +0100,
Stefan Binding wrote:
>
> @@ -8926,7 +8953,21 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),
> - SND_PCI_QUIRK(0x103c, 0x89c3, "HP", ALC285_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x896E, "HP EliteBook x360 830 G9", ALC245_FIXUP_CS35L41_SPI_2),

Please use lower letters for the hex number to align with others.
(Also other lines you've added.)

Though, it's no urgent problem, and we can fix it later if the whole
patch set can be merged now. If v3 needs to be respinned, please
apply the fix.

With the correction to be done,

Acked-by: Takashi Iwai <tiwai@suse.de>

thanks,

Takashi