From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC03EC433EF for ; Sun, 23 Jan 2022 15:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238011AbiAWPor convert rfc822-to-8bit (ORCPT ); Sun, 23 Jan 2022 10:44:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235444AbiAWPoq (ORCPT ); Sun, 23 Jan 2022 10:44:46 -0500 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEB4CC06173B for ; Sun, 23 Jan 2022 07:44:45 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 53F29100004; Sun, 23 Jan 2022 15:44:42 +0000 (UTC) Date: Sun, 23 Jan 2022 16:44:41 +0100 From: Miquel Raynal To: Jiasheng Jiang Cc: kyungmin.park@samsung.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mtd: onenand: Check for error irq Message-ID: <20220123164441.4ac98b08@xps13> In-Reply-To: <20220104162658.1988142-1-jiasheng@iscas.ac.cn> References: <20220104162658.1988142-1-jiasheng@iscas.ac.cn> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiasheng, jiasheng@iscas.ac.cn wrote on Wed, 5 Jan 2022 00:26:58 +0800: > For the possible failure of the platform_get_irq(), the returned irq > could be error number and will finally cause the failure of the > request_irq(). > Consider that platform_get_irq() can now in certain cases return > -EPROBE_DEFER, and the consequences of letting request_irq() effectively > convert that into -EINVAL, even at probe time rather than later on. > So it might be better to check just now. > > Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support") > Signed-off-by: Jiasheng Jiang > --- Applied to nand/next. Thanks, Miquèl