From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alexander Aring <aahringo@redhat.com>,
"Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
David Teigland <teigland@redhat.com>,
cluster-devel <cluster-devel@redhat.com>,
linux-sparse@vger.kernel.org, rcu@vger.kernel.org
Subject: Re: fs/dlm/midcomms.c:913:22: sparse: sparse: restricted __le32 degrades to integer
Date: Mon, 24 Jan 2022 15:45:30 +0300 [thread overview]
Message-ID: <20220124124530.GS1951@kadam> (raw)
In-Reply-To: <CAK-6q+j2jc3pBmbvQ-DCmxveC-UMV75SFc2nC1zwXKe9wm4YPg@mail.gmail.com>
On Sun, Jan 23, 2022 at 01:41:52PM -0500, Alexander Aring wrote:
>
> I see also:
>
> fs/dlm/midcomms.c:213:1: sparse: sparse: symbol
> '__srcu_struct_nodes_srcu' was not declared. Should it be static?
>
Why not just do this? (Untested. Maybe I don't understand?)
diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h
index cb1f4351e8ba..a164089abec4 100644
--- a/include/linux/srcutree.h
+++ b/include/linux/srcutree.h
@@ -121,7 +121,7 @@ struct srcu_struct {
#ifdef MODULE
# define __DEFINE_SRCU(name, is_static) \
is_static struct srcu_struct name; \
- struct srcu_struct * const __srcu_struct_##name \
+ is_static struct srcu_struct * const __srcu_struct_##name \
__section("___srcu_struct_ptrs") = &name
#else
# define __DEFINE_SRCU(name, is_static) \
next prev parent reply other threads:[~2022-01-24 12:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 2:45 fs/dlm/midcomms.c:913:22: sparse: sparse: restricted __le32 degrades to integer kernel test robot
2022-01-22 18:28 ` Alexander Aring
2022-01-22 19:18 ` Randy Dunlap
2022-01-23 18:41 ` Alexander Aring
2022-01-24 12:45 ` Dan Carpenter [this message]
2022-01-24 17:21 ` Alexander Aring
2022-01-24 17:36 ` Alexander Aring
2022-01-24 17:41 ` Alexander Aring
2022-01-24 20:14 ` Paul E. McKenney
2022-01-24 21:36 ` Alexander Aring
2022-01-24 22:06 ` Paul E. McKenney
2022-01-25 22:35 ` Alexander Aring
2022-01-26 14:39 ` Alexander Aring
2022-02-14 5:13 ` Al Viro
2022-02-14 12:47 ` Alexander Aring
-- strict thread matches above, loose matches on Subject: below --
2022-01-24 22:45 kernel test robot
2022-01-26 2:28 kernel test robot
2022-02-07 18:21 kernel test robot
2022-02-08 22:19 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124124530.GS1951@kadam \
--to=dan.carpenter@oracle.com \
--cc=aahringo@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paulmck@linux.ibm.com \
--cc=rcu@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).