From: kernel test robot <lkp@intel.com>
To: Hao Lee <haolee.swjtu@gmail.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
0day robot <lkp@intel.com>, Alexey Dobriyan <adobriyan@gmail.com>
Subject: [PATCH] proc: fix alloc_cast.cocci warnings
Date: Tue, 25 Jan 2022 09:13:28 +0800 [thread overview]
Message-ID: <20220125011328.GA21479@a311be8fcee1> (raw)
In-Reply-To: <202201250941.1xbLnDRA-lkp@intel.com>
From: kernel test robot <lkp@intel.com>
fs/proc/base.c:1767:14-18: WARNING: casting value returned by memory allocation function to (char *) is useless.
Remove casting the values returned by memory allocation functions
like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc.
Semantic patch information:
This makes an effort to find cases of casting of values returned by
kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc,
kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes
the casting as it is not required. The result in the patch case may
need some reformatting.
Generated by: scripts/coccinelle/api/alloc/alloc_cast.cocci
CC: Hao Lee <haolee.swjtu@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/0day-ci/linux/commits/UPDATE-20220123-215907/Hao-Lee/proc-use-kmalloc-instead-of-__get_free_page-to-alloc-path-buffer/20220123-181005
head: 98106e76de95ae9aefa914ec056448a5571155dc
commit: 98106e76de95ae9aefa914ec056448a5571155dc proc: alloc PATH_MAX bytes for /proc/${pid}/fd/ symlinks
:::::: branch date: 35 hours ago
:::::: commit date: 35 hours ago
base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1764,7 +1764,7 @@ out:
static int do_proc_readlink(struct path *path, char __user *buffer, int buflen)
{
- char *tmp = (char *)kmalloc(PATH_MAX, GFP_KERNEL);
+ char *tmp = kmalloc(PATH_MAX, GFP_KERNEL);
char *pathname;
int len;
next prev parent reply other threads:[~2022-01-25 3:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 2:35 fs/proc/base.c:1767:14-18: WARNING: casting value returned by memory allocation function to (char *) is useless kernel test robot
2022-01-25 1:13 ` kernel test robot [this message]
2022-01-25 3:01 ` Hao Lee
2022-01-25 6:05 ` Hao Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125011328.GA21479@a311be8fcee1 \
--to=lkp@intel.com \
--cc=adobriyan@gmail.com \
--cc=haolee.swjtu@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox