From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0F8C433F5 for ; Tue, 25 Jan 2022 16:15:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1583027AbiAYQPw (ORCPT ); Tue, 25 Jan 2022 11:15:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:64893 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1583418AbiAYQNL (ORCPT ); Tue, 25 Jan 2022 11:13:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643127191; x=1674663191; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZhVMjcdlxj873VdA6sEVIlWL3XJpbJPYkvwqeD4zZWU=; b=MJU0uhxfxEo8eRPab4ps3CTe/l0WFeO4OyaItRaEhKODsIhK7123sbB+ UBp2hB24ui0/rElFuf+0+iQpu+8NBq8+rPxt8lqzzfk3tXj10a5Ksxipe 0wRC3D/vPbhAvw16tiVsmCxWFTlE/QZrP3Qukk0C1dUO9xvHyPb199Ti9 3+ZpsaACep1hkbtU4tkBsDuZnfASBitfNikhiEs0cI+hco5WZYvtaJN1G 8FHsrzH/m6k7uDzGMGtki4qabzA24k+cDv2QIVycjL/MyeWl2dbcLXXXJ 7Isi6YPnE4iGxvNoDZnBumwJH60EFaQYfPdlZJ37YO61x6g9SQy1vDZ8F Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="233710407" X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="233710407" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 08:13:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="495043769" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 25 Jan 2022 08:13:05 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nCORN-000K85-Aq; Tue, 25 Jan 2022 16:13:05 +0000 Date: Wed, 26 Jan 2022 00:12:11 +0800 From: kernel test robot To: Hannes Reinecke Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Chaitanya Kulkarni , Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: [PATCH] nvme-fabrics: fix returnvar.cocci warnings Message-ID: <20220125161210.GA42603@d3bbc358300d> References: <202201260046.otELTDdH-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202201260046.otELTDdH-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") CC: Hannes Reinecke Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a08b41ab9e2e468647f78eb17c28e29b93006394 commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics :::::: branch date: 10 hours ago :::::: commit date: 5 weeks ago fabrics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str static int nvmf_dev_show(struct seq_file *seq_file, void *private) { struct nvme_ctrl *ctrl; - int ret = 0; mutex_lock(&nvmf_dev_mutex); ctrl = seq_file->private; @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file out_unlock: mutex_unlock(&nvmf_dev_mutex); - return ret; + return 0; } static int nvmf_dev_open(struct inode *inode, struct file *file)