* [PATCH][next] hwspinlock: sprd: Use struct_size() helper in devm_kzalloc()
@ 2022-01-25 22:57 Gustavo A. R. Silva
2022-01-26 3:31 ` Baolin Wang
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2022-01-25 22:57 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Baolin Wang, Orson Zhai,
Chunyan Zhang
Cc: linux-remoteproc, linux-kernel, Gustavo A. R. Silva,
linux-hardening
Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.
Also, address the following sparse warnings:
drivers/hwspinlock/sprd_hwspinlock.c:96:36: warning: using sizeof on a flexible structure
Link: https://github.com/KSPP/linux/issues/174
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/hwspinlock/sprd_hwspinlock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c
index d221fc9d756d..22e2ffb91743 100644
--- a/drivers/hwspinlock/sprd_hwspinlock.c
+++ b/drivers/hwspinlock/sprd_hwspinlock.c
@@ -93,8 +93,7 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev)
return -ENODEV;
sprd_hwlock = devm_kzalloc(&pdev->dev,
- sizeof(struct sprd_hwspinlock_dev) +
- SPRD_HWLOCKS_NUM * sizeof(*lock),
+ struct_size(sprd_hwlock, bank.lock, SPRD_HWLOCKS_NUM),
GFP_KERNEL);
if (!sprd_hwlock)
return -ENOMEM;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] hwspinlock: sprd: Use struct_size() helper in devm_kzalloc()
2022-01-25 22:57 [PATCH][next] hwspinlock: sprd: Use struct_size() helper in devm_kzalloc() Gustavo A. R. Silva
@ 2022-01-26 3:31 ` Baolin Wang
0 siblings, 0 replies; 2+ messages in thread
From: Baolin Wang @ 2022-01-26 3:31 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Ohad Ben-Cohen, Bjorn Andersson, Orson Zhai, Chunyan Zhang,
linux-remoteproc, LKML, linux-hardening
On Wed, Jan 26, 2022 at 6:50 AM Gustavo A. R. Silva
<gustavoars@kernel.org> wrote:
>
> Make use of the struct_size() helper instead of an open-coded version,
> in order to avoid any potential type mistakes or integer overflows that,
> in the worst scenario, could lead to heap overflows.
>
> Also, address the following sparse warnings:
> drivers/hwspinlock/sprd_hwspinlock.c:96:36: warning: using sizeof on a flexible structure
>
> Link: https://github.com/KSPP/linux/issues/174
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
LGTM.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
> drivers/hwspinlock/sprd_hwspinlock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c
> index d221fc9d756d..22e2ffb91743 100644
> --- a/drivers/hwspinlock/sprd_hwspinlock.c
> +++ b/drivers/hwspinlock/sprd_hwspinlock.c
> @@ -93,8 +93,7 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev)
> return -ENODEV;
>
> sprd_hwlock = devm_kzalloc(&pdev->dev,
> - sizeof(struct sprd_hwspinlock_dev) +
> - SPRD_HWLOCKS_NUM * sizeof(*lock),
> + struct_size(sprd_hwlock, bank.lock, SPRD_HWLOCKS_NUM),
> GFP_KERNEL);
> if (!sprd_hwlock)
> return -ENOMEM;
> --
> 2.27.0
>
--
Baolin Wang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-26 3:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-25 22:57 [PATCH][next] hwspinlock: sprd: Use struct_size() helper in devm_kzalloc() Gustavo A. R. Silva
2022-01-26 3:31 ` Baolin Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox