From: Eric Snowberg <eric.snowberg@oracle.com>
To: dhowells@redhat.com, dwmw2@infradead.org, ardb@kernel.org,
jarkko@kernel.org
Cc: jmorris@namei.org, serge@hallyn.com, eric.snowberg@oracle.com,
nayna@linux.ibm.com, zohar@linux.ibm.com, keescook@chromium.org,
torvalds@linux-foundation.org, weiyongjun1@huawei.com,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org,
James.Bottomley@HansenPartnership.com, pjones@redhat.com,
konrad.wilk@oracle.com
Subject: [PATCH v10 1/8] integrity: Fix warning about missing prototypes
Date: Tue, 25 Jan 2022 21:58:27 -0500 [thread overview]
Message-ID: <20220126025834.255493-2-eric.snowberg@oracle.com> (raw)
In-Reply-To: <20220126025834.255493-1-eric.snowberg@oracle.com>
make W=1 generates the following warning in keyring_handler.c
security/integrity/platform_certs/keyring_handler.c:71:30: warning: no previous prototype for get_handler_for_db [-Wmissing-prototypes]
__init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
^~~~~~~~~~~~~~~~~~
security/integrity/platform_certs/keyring_handler.c:82:30: warning: no previous prototype for get_handler_for_dbx [-Wmissing-prototypes]
__init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)
^~~~~~~~~~~~~~~~~~~
Add the missing prototypes by including keyring_handler.h.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Tested-by: Mimi Zohar <zohar@linux.ibm.com>
---
v7: Initial version
v8: Code unmodified from v7 added Mimi's Reviewed-by
v9: Unmodified from v8
v10: Added Jarkko's Reviewed-by and Mimi's Tested-by
---
security/integrity/platform_certs/keyring_handler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/integrity/platform_certs/keyring_handler.c b/security/integrity/platform_certs/keyring_handler.c
index 5604bd57c990..e9791be98fd9 100644
--- a/security/integrity/platform_certs/keyring_handler.c
+++ b/security/integrity/platform_certs/keyring_handler.c
@@ -9,6 +9,7 @@
#include <keys/asymmetric-type.h>
#include <keys/system_keyring.h>
#include "../integrity.h"
+#include "keyring_handler.h"
static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
static efi_guid_t efi_cert_x509_sha256_guid __initdata =
--
2.18.4
next prev parent reply other threads:[~2022-01-26 3:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 2:58 [PATCH v10 0/8] Enroll kernel keys thru MOK Eric Snowberg
2022-01-26 2:58 ` Eric Snowberg [this message]
2022-01-26 2:58 ` [PATCH v10 2/8] integrity: Introduce a Linux keyring called machine Eric Snowberg
2022-01-26 2:58 ` [PATCH v10 3/8] integrity: add new keyring handler for mok keys Eric Snowberg
2022-01-26 2:58 ` [PATCH v10 4/8] KEYS: store reference to machine keyring Eric Snowberg
2022-01-26 2:58 ` [PATCH v10 5/8] KEYS: Introduce link restriction for machine keys Eric Snowberg
2022-01-26 2:58 ` [PATCH v10 6/8] efi/mokvar: move up init order Eric Snowberg
2022-01-26 2:58 ` [PATCH v10 7/8] integrity: Trust MOK keys if MokListTrustedRT found Eric Snowberg
2022-01-26 2:58 ` [PATCH v10 8/8] integrity: Only use machine keyring when uefi_check_trust_mok_keys is true Eric Snowberg
2022-04-11 11:06 ` Michal Suchánek
2022-04-11 16:39 ` Eric Snowberg
2022-04-11 17:24 ` Michal Suchánek
2022-04-11 20:34 ` Eric Snowberg
2022-04-11 21:35 ` Michal Suchánek
2022-01-26 13:43 ` [PATCH v10 0/8] Enroll kernel keys thru MOK Jarkko Sakkinen
2022-01-26 13:58 ` Jarkko Sakkinen
2022-01-26 22:06 ` Mimi Zohar
2022-02-08 9:28 ` Jarkko Sakkinen
2022-02-08 15:26 ` MAINTAINERS update suggestion (subject change) Mimi Zohar
2022-02-20 19:00 ` [PATCH v10 0/8] Enroll kernel keys thru MOK Jarkko Sakkinen
2022-02-22 11:59 ` Mimi Zohar
2022-02-22 12:26 ` Jarkko Sakkinen
2022-02-22 12:32 ` Mimi Zohar
2022-02-23 15:32 ` Jarkko Sakkinen
2022-02-22 13:43 ` Mimi Zohar
2022-02-23 15:33 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126025834.255493-2-eric.snowberg@oracle.com \
--to=eric.snowberg@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ardb@kernel.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=pjones@redhat.com \
--cc=serge@hallyn.com \
--cc=torvalds@linux-foundation.org \
--cc=weiyongjun1@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox