Re: [PATCH] perf test: Add perf_event_attr tests for the arm_spe event

Leo Yan
2022-02-07T11:06:56Z

On Mon, Feb 07, 2022 at 10:50:26AM +0000, German Gomez wrote:
> Hi Leo, thanks for checking this
>
> On 05/02/2022 08:10, Leo Yan wrote:
> > Hi German,
> >
> > On Wed, Jan 26, 2022 at 04:07:09PM +0000, German Gomez wrote:
> >> Adds a couple of perf_event_attr tests for the fix introduced in [1].
> >> The tests check that the correct sample_period value is set in the
> >> struct perf_event_attr of the arm_spe events.
> >>
> >> [1]: https://lore.kernel.org/all/20220118144054.2541-1-german.gomez@arm.com/
> >>
> >> Signed-off-by: German Gomez <german.gomez@arm.com>
> > I tested this patch with two commands:
> >
> > # PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py -d ./tests/attr/ \
> > -p ./perf -vvvvv -t test-record-spe-period
> > # PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py -d ./tests/attr/ \
> > -p ./perf -vvvvv -t test-record-spe-period-term
> >
> > Both testing can pass on Hisilicon D06 board.
> >
> > One question: I'm a bit concern this case will fail on some Arm64
> > platforms which doesn't contain Arm SPE modules. E.g. below commands
> > will always fail on Arm64 platforms if SPE module is absent. So I am
> > wandering if we can add extra checking ARM SPE event is existed or not?
>
> The test reports "unsupported" if the return code and the 'ret' field don't match.
>
> When I unload the SPE module:
>
> running './tests/attr//test-record-spe-period-term'
> test limitation 'aarch64'
> unsupp  './tests/attr//test-record-spe-period-term'

Thanks for confirmation, German.

You could add my testing tag for this patch:

Tested-by: Leo Yan <leo.yan@linaro.org>