Re: [PATCH V8 36/44] memremap_pages: Reserve a PKS PKey for eventual use by PMEM

Ira Weiny
2022-02-08T23:42:20Z

On Tue, Feb 08, 2022 at 03:22:22PM -0800, Dan Williams wrote:
> On Tue, Feb 8, 2022 at 2:48 PM Ira Weiny <ira.weiny@intel.com> wrote:
> [..]
> > * // 5) Add initial value to PKS_INIT_VALUE
> > * #define PKS_INIT_VALUE ((PKS_ALL_AD & (GENMASK(31, PKS_KEY_MAX * PKR_BITS_PER_PKEY))) | \
> > * PKS_KEY_DEFAULT_INIT | \
> > * PKS_KEY_MY_FEATURE_INIT | \
>
> Does this compile? I.e. can you have a '|' operator with nothing on
> the right hand side?

Oops... yes but only because this is a comment (kernel doc) from the compiler
POV. Thanks I'll fix it.

>
> > * )
> > */
> >
> >
> > Let me know if this is clear enough?
>
> Looks good to me.

Thanks,
Ira