Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

Andy Shevchenko
2022-02-01T09:42:21Z

On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote:
> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:

...

> > +config TINYDRM_SSD1307
> > + tristate "DRM support for Solomon SSD1307 OLED displays"
> Use SSD130X here - so SSD1306 users can find it.

It's better to list them all in the "help". How user would grep this?

`git grep -n -i ssd1306` ==> no match.

> > + depends on DRM && I2C
> > + select DRM_KMS_HELPER
> > + select DRM_GEM_SHMEM_HELPER
> > + select BACKLIGHT_CLASS_DEVICE
> > + help
> > + DRM driver for the SSD1305, SSD1306, SSD1307 and SSD1309 Solomon
> > + OLED controllers that can be programmed via an I2C interface.
> > +
> > + If M is selected the module will be called ssd1307.

--
With Best Regards,
Andy Shevchenko