Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

Javier Martinez Canillas
2022-02-01T11:41:04Z

On 2/1/22 10:41, Andy Shevchenko wrote:
> On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote:
>> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
>
> ...
>
>>> +config TINYDRM_SSD1307
>>> + tristate "DRM support for Solomon SSD1307 OLED displays"
>> Use SSD130X here - so SSD1306 users can find it.
>
> It's better to list them all in the "help". How user would grep this?
>
> `git grep -n -i ssd1306` ==> no match.
>

That's already the case :)

$ git grep -n -i ssd1306 drivers/gpu/drm/
drivers/gpu/drm/tiny/Kconfig:167: DRM driver for the SSD1305, SSD1306, SSD1307 and SSD1309 Solomon
drivers/gpu/drm/tiny/ssd1307.c:922:static struct ssd1307_deviceinfo ssd1307_ssd1306_deviceinfo = {
drivers/gpu/drm/tiny/ssd1307.c:948: .compatible = "solomon,ssd1306fb-i2c",
drivers/gpu/drm/tiny/ssd1307.c:949: .data = (void *)&ssd1307_ssd1306_deviceinfo,

Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat