From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Sanjay R Mehta <sanju.mehta@amd.com>,
Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ptdma: Fix the error handling path in pt_core_init()
Date: Wed, 2 Feb 2022 10:15:31 +0300 [thread overview]
Message-ID: <20220202071530.GV1951@kadam> (raw)
In-Reply-To: <1b2573cf3cd077494531993239f80c08e7feb39e.1643551909.git.christophe.jaillet@wanadoo.fr>
On Sun, Jan 30, 2022 at 03:12:09PM +0100, Christophe JAILLET wrote:
> @@ -230,7 +230,7 @@ int pt_core_init(struct pt_device *pt)
> /* Request an irq */
> ret = request_irq(pt->pt_irq, pt_core_irq_handler, 0, dev_name(pt->dev), pt);
> if (ret)
> - goto e_pool;
> + goto e_dma_alloc;
These are ComeFrom label names. It's an unfortunate style of naming
labels based on the goto location instead of saying what the goto does.
This is one of those cases where the code has moved on, and now the name
no longer points to where it came from or to where it's going. It just
stands as a Hyperart Thomasson pointing to the past. It reminds us of
change and decay. Take time to smell the air in autumn. Beauty is all
around.
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-02 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 14:12 [PATCH] dmaengine: ptdma: Fix the error handling path in pt_core_init() Christophe JAILLET
2022-01-31 15:06 ` Sanjay R Mehta
2022-02-02 7:15 ` Dan Carpenter [this message]
2022-02-02 18:45 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202071530.GV1951@kadam \
--to=dan.carpenter@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanju.mehta@amd.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox