Re: [PATCH 4/4 v5] fortify: Add Clang support

Nick Desaulniers
2022-02-02T21:27:30Z

On Tue, Feb 1, 2022 at 4:30 PM Kees Cook <keescook@chromium.org> wrote:
>
> +#define BOS const __pass_object_size(1)
> +#define BOS0 const __pass_object_size(0)

A dumb bikeshed, but would you mind naming these BOS1 and BOS0, and
perhaps consider adding a comment or pointer or link to something that
describes why we use the two different modes? I recognize that the
code already uses the two different modes already without comments,
but this might be a nice place to point folks like myself to so that
in a month or so when I forget what the difference is between modes
(again), we have a shorter trail of breadcrumbs.
--
Thanks,
~Nick Desaulniers