From: Bean Huo <huobean@gmail.com>
To: ulf.hansson@linaro.org, eugen.hristev@microchip.com,
adrian.hunter@intel.com, nicolas.ferre@microchip.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: beanhuo@micron.com
Subject: [PATCH 1/5] mmc: wmt-sdmmc: Use of_device_get_match_data() helper
Date: Wed, 2 Feb 2022 19:06:44 +0100 [thread overview]
Message-ID: <20220202180648.1252154-2-huobean@gmail.com> (raw)
In-Reply-To: <20220202180648.1252154-1-huobean@gmail.com>
From: Bean Huo <beanhuo@micron.com>
Only the device data is needed, not the whole struct of_device_id.
Use of_device_get_match_data() instead of open coding of of_match_device().
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
drivers/mmc/host/wmt-sdmmc.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
index cf10949fb0ac..163ac9df8cca 100644
--- a/drivers/mmc/host/wmt-sdmmc.c
+++ b/drivers/mmc/host/wmt-sdmmc.c
@@ -751,19 +751,16 @@ static int wmt_mci_probe(struct platform_device *pdev)
struct mmc_host *mmc;
struct wmt_mci_priv *priv;
struct device_node *np = pdev->dev.of_node;
- const struct of_device_id *of_id =
- of_match_device(wmt_mci_dt_ids, &pdev->dev);
const struct wmt_mci_caps *wmt_caps;
int ret;
int regular_irq, dma_irq;
- if (!of_id || !of_id->data) {
+ wmt_caps = of_device_get_match_data(&pdev->dev);
+ if (!wmt_caps) {
dev_err(&pdev->dev, "Controller capabilities data missing\n");
return -EFAULT;
}
- wmt_caps = of_id->data;
-
if (!np) {
dev_err(&pdev->dev, "Missing SDMMC description in devicetree\n");
return -EFAULT;
--
2.25.1
next prev parent reply other threads:[~2022-02-02 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 18:06 [PATCH 0/5] Use of_device_get_match_data() helper Bean Huo
2022-02-02 18:06 ` Bean Huo [this message]
2022-02-02 18:06 ` [PATCH 2/5] mmc: sdhci-tegra: " Bean Huo
2022-02-02 18:06 ` [PATCH 3/5] mmc: sdhci-omap: " Bean Huo
2022-02-03 2:39 ` kernel test robot
2022-02-03 4:21 ` kernel test robot
2022-02-02 18:06 ` [PATCH 4/5] mmc: sdhci-of-at91: " Bean Huo
2022-02-02 18:06 ` [PATCH 5/5] mmc: davinci: " Bean Huo
2022-02-08 15:12 ` [PATCH 0/5] " Ulf Hansson
2022-02-08 16:44 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202180648.1252154-2-huobean@gmail.com \
--to=huobean@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=beanhuo@micron.com \
--cc=eugen.hristev@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox