From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C40E5C433FE for ; Thu, 3 Feb 2022 19:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353903AbiBCT5t (ORCPT ); Thu, 3 Feb 2022 14:57:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235320AbiBCT5s (ORCPT ); Thu, 3 Feb 2022 14:57:48 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C66DC06173B for ; Thu, 3 Feb 2022 11:57:48 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id v3so3177733pgc.1 for ; Thu, 03 Feb 2022 11:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cGaByQ8siwOwFo3H6XR9VUUbom/VIgqp9w81CSI2uiw=; b=T92D31tAA5MiwOX/9m3Jeiumqwj0pecFkTk6CBukk20nvgu17OaKXN1AFtvgv57EKK jq70zxVaT7TPIB4Bc5IfKaIOWLzMDOYLs5SbK3iI9pc2pBwVHPciHGucPx4g5p7kADlq kbnX2qlS2n2xDOjJdk6xX/3F428RmLokW3rrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cGaByQ8siwOwFo3H6XR9VUUbom/VIgqp9w81CSI2uiw=; b=l/VpUGV9m8QCFBy0u1L4hCleQNfqUOpZm6mY8ZDRdGShFj+3F2uC23ydHYxKVaMvUr I2BEThlY47HvNClzhIChcENVlQIveMkss8Gb7NrXrKxtaXZAl+5eawAacx9XKHiD+Yqg AQPC3vuNZ/Mzu9n7234BHKqtxFkB4F2xAwgZY5/Df0apmdCIAVs0mKJnsSKfjoDbx2SM g+sMOU3BzDx9NCwd1h1WeoXTSEuHVYGpraX8/d4OO4APOHS38B8QZMtdjE1wfVNqbVeC rbmvejgMDEydCwaWEI6MfOfcfiqmFuUiFEJCbrLuJPMUwk1nGFqIkUUL2Mmf+z1JI6Sp e9ZA== X-Gm-Message-State: AOAM530cKZwv4QqAPf994ySGh5osFGcvsxBoTg/EHcGmbD5EOj7nMBJd 3HLPZm9jIYdigRQXjF3IOVo2zg== X-Google-Smtp-Source: ABdhPJzbNSRl7D+yCCPxB+1tEd531BtF9DNUrQKCK6weQRbjWpzkV6o1fNMvnURTVpjTcfO9QN+K6A== X-Received: by 2002:a63:d80b:: with SMTP id b11mr16714952pgh.189.1643918267952; Thu, 03 Feb 2022 11:57:47 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ck21sm10231314pjb.51.2022.02.03.11.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Feb 2022 11:57:47 -0800 (PST) Date: Thu, 3 Feb 2022 11:57:46 -0800 From: Kees Cook To: Miguel Ojeda Cc: Miguel Ojeda , Nick Desaulniers , Nathan Chancellor , George Burgess IV , linux-kernel , llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH v6 0/4] fortify: Add Clang support Message-ID: <202202031157.E18FA7BAC@keescook> References: <20220203173307.1033257-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 03, 2022 at 06:47:01PM +0100, Miguel Ojeda wrote: > On Thu, Feb 3, 2022 at 6:33 PM Kees Cook wrote: > > > > This has been updated from feedback on the v5 series. Builds correctly with Clang 12.0.1 > > too now. :) > > Looks fine to me! Thanks for the changes. I assume you are taking these, so: > > Reviewed-by: Miguel Ojeda Thanks! Does this tag apply to the fortify-string.h patch as well? -Kees -- Kees Cook