public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: linux-kernel@vger.kernel.org, Nitesh Lal <nilal@redhat.com>,
	Nicolas Saenz Julienne <nsaenzju@redhat.com>,
	Christoph Lameter <cl@linux.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Alex Belits <abelits@belits.com>, Peter Xu <peterx@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [patch v10 08/10] KVM: x86: process isolation work from VM-entry code path
Date: Thu, 3 Feb 2022 19:25:27 +0100	[thread overview]
Message-ID: <20220203182527.GB475173@lothringen> (raw)
In-Reply-To: <20220127173206.862057978@fedora.localdomain>

On Thu, Jan 27, 2022 at 02:30:45PM -0300, Marcelo Tosatti wrote:
> VM-entry code path is an entry point similar to userspace return
> when task isolation is concerned.
> 
> Call isolation_exit_to_user_mode before VM-enter.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> ---
>  include/linux/entry-kvm.h |    4 +++-
>  kernel/entry/kvm.c        |   18 ++++++++++++++----
>  2 files changed, 17 insertions(+), 5 deletions(-)
> 
> Index: linux-2.6/kernel/entry/kvm.c
> ===================================================================
> --- linux-2.6.orig/kernel/entry/kvm.c
> +++ linux-2.6/kernel/entry/kvm.c
> @@ -2,8 +2,11 @@
>  
>  #include <linux/entry-kvm.h>
>  #include <linux/kvm_host.h>
> +#include <linux/task_isolation.h>
>  
> -static int xfer_to_guest_mode_work(struct kvm_vcpu *vcpu, unsigned long ti_work)
> +static int xfer_to_guest_mode_work(struct kvm_vcpu *vcpu,
> +				   unsigned long ti_work,
> +				   unsigned long task_isol_work)
>  {
>  	do {
>  		int ret;
> @@ -25,15 +28,19 @@ static int xfer_to_guest_mode_work(struc
>  		ret = arch_xfer_to_guest_mode_handle_work(vcpu, ti_work);
>  		if (ret)
>  			return ret;
> +		if (task_isol_work)
> +			task_isol_exit_to_user_mode();
>  
>  		ti_work = read_thread_flags();
> -	} while (ti_work & XFER_TO_GUEST_MODE_WORK || need_resched());
> +	} while (ti_work & XFER_TO_GUEST_MODE_WORK || need_resched() ||
> +		 task_isol_work);

There too you should join the XFER_TO_GUEST_MODE_WORK mask.

Thanks.

  reply	other threads:[~2022-02-03 18:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 17:30 [patch v10 00/10] extensible prctl task isolation interface and vmstat sync Marcelo Tosatti
2022-01-27 17:30 ` [patch v10 01/10] add basic task isolation prctl interface Marcelo Tosatti
2022-01-29  4:22   ` [PATCH v10 1/10] " 向 景亘
2022-01-30 10:07     ` Oscar Shiang
2022-02-01 18:31     ` Marcelo Tosatti
2022-01-27 17:30 ` [patch v10 02/10] add prctl task isolation prctl docs and samples Marcelo Tosatti
2022-01-27 17:30 ` [patch v10 03/10] task isolation: sync vmstats on return to userspace Marcelo Tosatti
2022-01-27 17:30 ` [patch v10 04/10] procfs: add per-pid task isolation state Marcelo Tosatti
2022-01-27 17:30 ` [patch v10 05/10] task isolation: add hook to task exit Marcelo Tosatti
2022-02-03 18:23   ` Frederic Weisbecker
2022-01-27 17:30 ` [patch v10 06/10] task isolation: sync vmstats conditional on changes Marcelo Tosatti
2022-01-27 17:30 ` [patch v10 07/10] task isolation: enable return to userspace processing Marcelo Tosatti
2022-01-27 17:30 ` [patch v10 08/10] KVM: x86: process isolation work from VM-entry code path Marcelo Tosatti
2022-02-03 18:25   ` Frederic Weisbecker [this message]
2022-01-27 17:30 ` [patch v10 09/10] mm: vmstat: move need_update Marcelo Tosatti
2022-01-27 17:30 ` [patch v10 10/10] mm: vmstat_refresh: avoid queueing work item if cpu stats are clean Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220203182527.GB475173@lothringen \
    --to=frederic@kernel.org \
    --cc=abelits@belits.com \
    --cc=bristot@redhat.com \
    --cc=cl@linux.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=nilal@redhat.com \
    --cc=nsaenzju@redhat.com \
    --cc=peterx@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox