From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C210C433EF for ; Thu, 3 Feb 2022 20:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354954AbiBCUgx (ORCPT ); Thu, 3 Feb 2022 15:36:53 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:41000 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355099AbiBCUev (ORCPT ); Thu, 3 Feb 2022 15:34:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6428A61B03; Thu, 3 Feb 2022 20:34:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C8A2C36B08; Thu, 3 Feb 2022 20:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643920490; bh=XVFM1tXUzp/miplACsf4svGjDWRV9r3TUJTlD4CJNVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bhFUMb3mQ6JS3ZQQQPJorWgXF5fmSQ5VZ+HHccUnAHyweGMfNRYIoozgBvk+yK9DX FKc7Ve0fXy/N3JF/8aOBHoFDzJZpaMoYONEOgnEKMrsVPXyoFlWDTbr6qPDvdkU+Bg LH+W2tNhe2tdGXvkLhbpE/+cFkFhLEa8NRu1CRe8jCdzrSDDF325XzmI01llOtCR0/ nAL5nKKbmeOE87NkU00z/Tn6n6wjutQRUyjNrG5gIl0XhPXQZRez6sb3juV5rJzNJg wQ6IVy7o75rpHyvFfuhyXN/FQYxjWluwheGp6aUmlWRuvIGhaPLJ2LWEDuvhzsoQ93 vEpvsoKlignKw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Olga Kornievskaia , Anna Schumaker , Sasha Levin , trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, linux-nfs@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 02/25] NFSv4 only print the label when its queried Date: Thu, 3 Feb 2022 15:34:23 -0500 Message-Id: <20220203203447.3570-2-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220203203447.3570-1-sashal@kernel.org> References: <20220203203447.3570-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olga Kornievskaia [ Upstream commit 2c52c8376db7160a1dd8a681c61c9258405ef143 ] When the bitmask of the attributes doesn't include the security label, don't bother printing it. Since the label might not be null terminated, adjust the printing format accordingly. Signed-off-by: Olga Kornievskaia Signed-off-by: Anna Schumaker Signed-off-by: Sasha Levin --- fs/nfs/nfs4xdr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index c16b93df1bc14..9f8bd45379e72 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c @@ -4184,10 +4184,11 @@ static int decode_attr_security_label(struct xdr_stream *xdr, uint32_t *bitmap, } else printk(KERN_WARNING "%s: label too long (%u)!\n", __func__, len); + if (label && label->label) + dprintk("%s: label=%.*s, len=%d, PI=%d, LFS=%d\n", + __func__, label->len, (char *)label->label, + label->len, label->pi, label->lfs); } - if (label && label->label) - dprintk("%s: label=%s, len=%d, PI=%d, LFS=%d\n", __func__, - (char *)label->label, label->len, label->pi, label->lfs); return status; } -- 2.34.1