public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
	rostedt@goodmis.org, "Paul E. McKenney" <paulmck@kernel.org>
Subject: [PATCH rcu 2/8] torture: Distinguish kthread stopping and being asked to stop
Date: Fri,  4 Feb 2022 15:53:21 -0800	[thread overview]
Message-ID: <20220204235327.2948-2-paulmck@kernel.org> (raw)
In-Reply-To: <20220204235321.GA2511@paulmck-ThinkPad-P17-Gen-1>

Right now, if a given kthread (call it "kthread") realizes that it needs
to stop, "Stopping kthread" is written to the console.  When the cleanup
code decides that it is time to stop that kthread, "Stopping kthread
tasks" is written to the console.  These two events might happen in
either order, especially in the case of time-based torture-test shutdown.

But it is hard to distinguish these, especially for those unfamiliar with
the torture tests.  This commit therefore changes the first case from
"Stopping kthread" to "kthread is stopping" to make things more clear.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
 kernel/torture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/torture.c b/kernel/torture.c
index ef27a6c824514..f55d803f995d4 100644
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -911,7 +911,7 @@ void torture_kthread_stopping(char *title)
 {
 	char buf[128];
 
-	snprintf(buf, sizeof(buf), "Stopping %s", title);
+	snprintf(buf, sizeof(buf), "%s is stopping", title);
 	VERBOSE_TOROUT_STRING(buf);
 	while (!kthread_should_stop()) {
 		torture_shutdown_absorb(title);
-- 
2.31.1.189.g2e36527f23


  parent reply	other threads:[~2022-02-04 23:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 23:53 [PATCH rcu 0/8] Torture-test updates for v5.18 Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 1/8] rcutorture: Print message before invoking ->cb_barrier() Paul E. McKenney
2022-02-04 23:53 ` Paul E. McKenney [this message]
2022-02-04 23:53 ` [PATCH rcu 3/8] rcutorture: Increase visibility of forward-progress hangs Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 4/8] rcutorture: Make rcu_fwd_cb_nodelay be a counter Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 5/8] rcutorture: Add end-of-test check to rcu_torture_fwd_prog() loop Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 6/8] rcutorture: Fix rcu_fwd_mutex deadlock Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 7/8] torture: Wake up kthreads after storing task_struct pointer Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 8/8] rcutorture: Enable limited callback-flooding tests of SRCU Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220204235327.2948-2-paulmck@kernel.org \
    --to=paulmck@kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox