From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
rostedt@goodmis.org, "Paul E. McKenney" <paulmck@kernel.org>
Subject: [PATCH rcu 5/8] rcutorture: Add end-of-test check to rcu_torture_fwd_prog() loop
Date: Fri, 4 Feb 2022 15:53:24 -0800 [thread overview]
Message-ID: <20220204235327.2948-5-paulmck@kernel.org> (raw)
In-Reply-To: <20220204235321.GA2511@paulmck-ThinkPad-P17-Gen-1>
The second and subsequent forward-progress kthreads loop waiting for
the first forward-progress kthread to start the next test interval.
Unfortunately, if the test ends while one of those kthreads is waiting,
the test will hang. This hang occurs because that wait loop fails to
check for the end of the test. This commit therefore adds an end-of-test
check to that wait loop.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/rcu/rcutorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index afe95c6948957..e99658efd97f4 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -2515,7 +2515,7 @@ static int rcu_torture_fwd_prog(void *args)
firsttime = false;
WRITE_ONCE(rcu_fwd_seq, rcu_fwd_seq + 1);
} else {
- while (READ_ONCE(rcu_fwd_seq) == oldseq)
+ while (READ_ONCE(rcu_fwd_seq) == oldseq && !torture_must_stop())
schedule_timeout_interruptible(1);
oldseq = READ_ONCE(rcu_fwd_seq);
}
--
2.31.1.189.g2e36527f23
next prev parent reply other threads:[~2022-02-04 23:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 23:53 [PATCH rcu 0/8] Torture-test updates for v5.18 Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 1/8] rcutorture: Print message before invoking ->cb_barrier() Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 2/8] torture: Distinguish kthread stopping and being asked to stop Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 3/8] rcutorture: Increase visibility of forward-progress hangs Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 4/8] rcutorture: Make rcu_fwd_cb_nodelay be a counter Paul E. McKenney
2022-02-04 23:53 ` Paul E. McKenney [this message]
2022-02-04 23:53 ` [PATCH rcu 6/8] rcutorture: Fix rcu_fwd_mutex deadlock Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 7/8] torture: Wake up kthreads after storing task_struct pointer Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 8/8] rcutorture: Enable limited callback-flooding tests of SRCU Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204235327.2948-5-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox