From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
rostedt@goodmis.org, "Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Uladzislau Rezki <urezki@gmail.com>
Subject: [PATCH rcu 7/8] torture: Wake up kthreads after storing task_struct pointer
Date: Fri, 4 Feb 2022 15:53:26 -0800 [thread overview]
Message-ID: <20220204235327.2948-7-paulmck@kernel.org> (raw)
In-Reply-To: <20220204235321.GA2511@paulmck-ThinkPad-P17-Gen-1>
Currently, _torture_create_kthread() uses kthread_run() to create
torture-test kthreads, which means that the resulting task_struct
pointer is stored after the newly created kthread has been marked
runnable. This in turn can cause spurious failure of checks for
code being run by a particular kthread. This commit therefore changes
_torture_create_kthread() to use kthread_create(), then to do an explicit
wake_up_process() after the task_struct pointer has been stored.
Reported-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Neeraj Upadhyay <quic_neeraju@quicinc.com>
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/torture.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/torture.c b/kernel/torture.c
index f55d803f995d4..789aeb0e1159c 100644
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -931,12 +931,14 @@ int _torture_create_kthread(int (*fn)(void *arg), void *arg, char *s, char *m,
int ret = 0;
VERBOSE_TOROUT_STRING(m);
- *tp = kthread_run(fn, arg, "%s", s);
+ *tp = kthread_create(fn, arg, "%s", s);
if (IS_ERR(*tp)) {
ret = PTR_ERR(*tp);
TOROUT_ERRSTRING(f);
*tp = NULL;
+ return ret;
}
+ wake_up_process(*tp); // Process is sleeping, so ordering provided.
torture_shuffle_task_register(*tp);
return ret;
}
--
2.31.1.189.g2e36527f23
next prev parent reply other threads:[~2022-02-04 23:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 23:53 [PATCH rcu 0/8] Torture-test updates for v5.18 Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 1/8] rcutorture: Print message before invoking ->cb_barrier() Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 2/8] torture: Distinguish kthread stopping and being asked to stop Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 3/8] rcutorture: Increase visibility of forward-progress hangs Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 4/8] rcutorture: Make rcu_fwd_cb_nodelay be a counter Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 5/8] rcutorture: Add end-of-test check to rcu_torture_fwd_prog() loop Paul E. McKenney
2022-02-04 23:53 ` [PATCH rcu 6/8] rcutorture: Fix rcu_fwd_mutex deadlock Paul E. McKenney
2022-02-04 23:53 ` Paul E. McKenney [this message]
2022-02-04 23:53 ` [PATCH rcu 8/8] rcutorture: Enable limited callback-flooding tests of SRCU Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204235327.2948-7-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=frederic@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox