From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
rostedt@goodmis.org, "Paul E. McKenney" <paulmck@kernel.org>,
Paul Menzel <pmenzel@molgen.mpg.de>
Subject: [PATCH rcu 09/13] torture: Make kvm-find-errors.sh notice missing vmlinux file
Date: Fri, 4 Feb 2022 15:55:57 -0800 [thread overview]
Message-ID: <20220204235601.3438-9-paulmck@kernel.org> (raw)
In-Reply-To: <20220204235558.GA3221@paulmck-ThinkPad-P17-Gen-1>
Currently, an obtuse compiler diagnostic can fool kvm-find-errors.sh
into believing that the build was successful. This commit therefore
adds a check for a missing vmlinux file. Note that in the case of
repeated torture-test scenarios ("--configs '2*TREE01'"), the vmlinux
file will only be present in the first directory, that is, in TREE01
but not TREE01.2.
Link: https://lore.kernel.org/lkml/36bd91e4-8eda-5677-7fde-40295932a640@molgen.mpg.de/
Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh b/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
index 2e9e9e2eedb69..5f682fc892dd4 100755
--- a/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
+++ b/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
@@ -30,10 +30,16 @@ editor=${EDITOR-vi}
files=
for i in ${rundir}/*/Make.out
do
+ scenariodir="`dirname $i`"
+ scenariobasedir="`echo ${scenariodir} | sed -e 's/\.[0-9]*$//'`"
if egrep -q "error:|warning:|^ld: .*undefined reference to" < $i
then
egrep "error:|warning:|^ld: .*undefined reference to" < $i > $i.diags
files="$files $i.diags $i"
+ elif ! test -f ${scenariobasedir}/vmlinux
+ then
+ echo No ${scenariobasedir}/vmlinux file > $i.diags
+ files="$files $i.diags $i"
fi
done
if test -n "$files"
--
2.31.1.189.g2e36527f23
next prev parent reply other threads:[~2022-02-04 23:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 23:55 [PATCH rcu 0/13] Torture-test scripting updates for v5.18 Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 01/13] torture: Drop trailing ^M from console output Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 02/13] torture: Allow four-digit repetition numbers for --configs parameter Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 03/13] torture: Output per-failed-run summary lines from torture.sh Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 04/13] torture: Make kvm.sh summaries note runs having only KCSAN reports Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 05/13] torture: Indicate which torture.sh runs' bugs are all " Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 06/13] torture: Compress KCSAN as well as KASAN vmlinux files Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 07/13] torture: Make kvm-remote.sh try multiple times to download tarball Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 08/13] torture: Print only one summary line per run Paul E. McKenney
2022-02-04 23:55 ` Paul E. McKenney [this message]
2022-02-04 23:55 ` [PATCH rcu 10/13] torture: Change KVM environment variable to RCUTORTURE Paul E. McKenney
2022-02-04 23:55 ` [PATCH rcu 11/13] torture: Make torture.sh help message match reality Paul E. McKenney
2022-02-04 23:56 ` [PATCH rcu 12/13] rcutorture: Test SRCU size transitions Paul E. McKenney
2022-02-04 23:56 ` [PATCH rcu 13/13] rcutorture: Provide non-power-of-two Tasks RCU scenarios Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204235601.3438-9-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox