From: "Dāvis Mosāns" <davispuh@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: "Chris Mason" <clm@fb.com>, "Josef Bacik" <josef@toxicpanda.com>,
"David Sterba" <dsterba@suse.com>,
linux-kernel@vger.kernel.org, "Dāvis Mosāns" <davispuh@gmail.com>
Subject: [PATCH v2] btrfs: send: in case of IO error log it
Date: Sat, 5 Feb 2022 03:36:07 +0200 [thread overview]
Message-ID: <20220205013606.532212-1-davispuh@gmail.com> (raw)
In-Reply-To: <20220202201437.7718-1-davispuh@gmail.com>
Currently if we get IO error while doing send then we abort without
logging information about which file caused issue.
So log it to help with debugging.
Signed-off-by: Dāvis Mosāns <davispuh@gmail.com>
---
fs/btrfs/send.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index d8ccb62aa7d2..a1fd449a5ecc 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -5000,6 +5000,8 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
if (!PageUptodate(page)) {
unlock_page(page);
put_page(page);
+ btrfs_err(fs_info, "send: IO error at offset=%llu for inode=%llu root=%llu",
+ page_offset(page), sctx->cur_ino, sctx->send_root->root_key.objectid);
ret = -EIO;
break;
}
--
2.35.1
next prev parent reply other threads:[~2022-02-05 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 20:14 [PATCH] btrfs: send: in case of IO error log inode Dāvis Mosāns
2022-02-04 16:28 ` David Sterba
2022-02-05 1:35 ` Dāvis Mosāns
2022-02-05 1:36 ` Dāvis Mosāns [this message]
2022-02-05 18:50 ` [PATCH v2] btrfs: send: in case of IO error log it Dāvis Mosāns
2022-02-05 18:48 ` [PATCH v3] " Dāvis Mosāns
2022-02-08 23:04 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220205013606.532212-1-davispuh@gmail.com \
--to=davispuh@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox