From: Stephen Boyd <sboyd@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Taniya Das <tdas@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] clk: qcom: sc7280: Update clk_init_data to const for clock controllers
Date: Fri, 04 Feb 2022 18:48:26 -0800 [thread overview]
Message-ID: <20220205024828.76942C004E1@smtp.kernel.org> (raw)
In-Reply-To: <CAA8EJpqWUm5C5nc3fZzjF4XfAEZo8m=PY0Rj6WeDgSJEey=D_A@mail.gmail.com>
Quoting Dmitry Baryshkov (2022-02-02 14:34:11)
> On Wed, 2 Feb 2022 at 21:23, Taniya Das <tdas@codeaurora.org> wrote:
> >
> > Update clk_init_data to const and also use index instead of fw_name for
> > graphics, lpasscc and video clock controller.
>
> What is the benefit from using indices here? In my opinion the code
> becomes more fragile with such a change.
The benefit is smaller code size. Please run scripts/bloat-o-meter
prev parent reply other threads:[~2022-02-05 2:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 18:20 [PATCH v1 1/2] clk: qcom: sc7280: Update clk_init_data to const for clock controllers Taniya Das
2022-02-02 18:20 ` [PATCH v1 2/2] " Taniya Das
2022-02-02 22:34 ` Dmitry Baryshkov
2022-02-05 2:48 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220205024828.76942C004E1@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox