public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>
Subject: Re: [PATCH v1 1/1] iio: accel: adxl355: Replace custom definitions with generic from units.h
Date: Sat, 5 Feb 2022 17:41:08 +0000	[thread overview]
Message-ID: <20220205174108.094da325@jic23-huawei> (raw)
In-Reply-To: <20220202173723.8678-1-andriy.shevchenko@linux.intel.com>

On Wed,  2 Feb 2022 19:37:23 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> The units.h provides MEGA and TERA. Replace custom ones.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied,

Thanks,

Jonathan

> ---
>  drivers/iio/accel/adxl355_core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c
> index 4f485909f459..7023de888835 100644
> --- a/drivers/iio/accel/adxl355_core.c
> +++ b/drivers/iio/accel/adxl355_core.c
> @@ -20,6 +20,8 @@
>  #include <linux/mod_devicetable.h>
>  #include <linux/of_irq.h>
>  #include <linux/regmap.h>
> +#include <linux/units.h>
> +
>  #include <asm/unaligned.h>
>  
>  #include "adxl355.h"
> @@ -60,9 +62,6 @@
>  #define ADXL355_PARTID_VAL		0xED
>  #define ADXL355_RESET_CODE		0x52
>  
> -#define MEGA 1000000UL
> -#define TERA 1000000000000ULL
> -
>  static const struct regmap_range adxl355_read_reg_range[] = {
>  	regmap_reg_range(ADXL355_DEVID_AD_REG, ADXL355_FIFO_DATA_REG),
>  	regmap_reg_range(ADXL355_OFFSET_X_H_REG, ADXL355_SELF_TEST_REG),


      reply	other threads:[~2022-02-05 17:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02 17:37 [PATCH v1 1/1] iio: accel: adxl355: Replace custom definitions with generic from units.h Andy Shevchenko
2022-02-05 17:41 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220205174108.094da325@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=puranjay12@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox