From: Guenter Roeck <linux@roeck-us.net>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: BUG: [PATCH v2] isoc: mediatek: Check for error clk pointer
Date: Sun, 6 Feb 2022 09:37:54 -0800 [thread overview]
Message-ID: <20220206173754.GA2014863@roeck-us.net> (raw)
In-Reply-To: <trinity-2a727d96-0335-4d03-8f30-e22a0e10112d-1643363480085@3c-app-gmx-bap33>
On Fri, Jan 28, 2022 at 10:51:20AM +0100, Frank Wunderlich wrote:
> Hi,
>
> this commit is merged in 5.17-rc1 and breaks scpsys on mt7622/bananapi R64
>
> mtk-scpsys: probe of 10006000.power-controller failed with error -2
>
> at least ethernet is affected (i guess usb,sata,btif,... too, but not checked), as gmacs do not get probed as depency of it
>
> after reverting this commit it is working again.
>
> have not yet digged deeper into it why it is failing, but maybe author has an idea
>
I created a revert of the problematic patch with some explanation.
https://lore.kernel.org/lkml/20220205014755.699603-1-linux@roeck-us.net/
Sorry that I didn't reference this discussion; I only noticed it after
I wrote the revert. The revert and my analysis is based on the impact
of this patch on affected Chromebooks.
The revert is queued for v4.19.y and later stable releases because
the patch discussed here made it into all those releases and breaks
pretty much all Mediatek based systems using the affected driver.
Guenter
next prev parent reply other threads:[~2022-02-06 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 1:51 [PATCH v2] isoc: mediatek: Check for error clk pointer Jiasheng Jiang
2021-12-24 14:06 ` Mark Brown
2021-12-24 16:17 ` Mark Brown
2022-01-28 9:51 ` BUG: " Frank Wunderlich
2022-02-06 17:37 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-28 14:26 Paul Mulders
2022-01-28 14:31 Paul Mulders
2022-01-30 2:43 Jiasheng Jiang
2022-02-01 22:19 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220206173754.GA2014863@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@kernel.org \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox