From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Cc: <vigneshr@ti.com>, <richard@nod.at>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<git@xilinx.com>
Subject: Re: [PATCH] mtd: rawnand: pl353: Set the nand chip node as the flash node
Date: Tue, 8 Feb 2022 14:05:51 +0100 [thread overview]
Message-ID: <20220208140551.6271f976@xps13> (raw)
In-Reply-To: <20220208125738.32162-1-amit.kumar-mahapatra@xilinx.com>
Hi Amit,
amit.kumar-mahapatra@xilinx.com wrote on Tue, 8 Feb 2022 18:27:38 +0530:
> In devicetree the flash information is embedded within nand chip node,
> so during nand chip initialization the nand chip node should be passed
> to nand_set_flash_node() api, instead of nand controller node.
>
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Can you please add Fixes tag?
> ---
> BRANCH: nand/next
> ---
> drivers/mtd/nand/raw/pl35x-nand-controller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c
> index 8a91e069ee2e..3c6f6aff649f 100644
> --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c
> +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c
> @@ -1062,7 +1062,7 @@ static int pl35x_nand_chip_init(struct pl35x_nandc *nfc,
> chip->controller = &nfc->controller;
> mtd = nand_to_mtd(chip);
> mtd->dev.parent = nfc->dev;
> - nand_set_flash_node(chip, nfc->dev->of_node);
> + nand_set_flash_node(chip, np);
> if (!mtd->name) {
> mtd->name = devm_kasprintf(nfc->dev, GFP_KERNEL,
> "%s", PL35X_NANDC_DRIVER_NAME);
yup, that was wrong.
Thanks,
Miquèl
prev parent reply other threads:[~2022-02-08 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 12:57 [PATCH] mtd: rawnand: pl353: Set the nand chip node as the flash node Amit Kumar Mahapatra
2022-02-08 13:05 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208140551.6271f976@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=amit.kumar-mahapatra@xilinx.com \
--cc=git@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox