Re: [PATCH v2 09/10] iommu: Use dev_iommu_ops() helper

Christoph Hellwig
2022-02-09T06:45:11Z

On Tue, Feb 08, 2022 at 09:25:58AM +0800, Lu Baolu wrote:
> Convert all the feasible instances of dev->bus->iommu_ops to
> dev_iommu_ops() in order to making the operation of obtaining
> iommu_ops from a device consistent.

I'm not a native speaker, but I think this should read ".. in order to
make .."

> void iommu_get_resv_regions(struct device *dev, struct list_head *list)
> {
> - const struct iommu_ops *ops = dev->bus->iommu_ops;
> + const struct iommu_ops *ops = dev_iommu_ops(dev);
>
> if (ops && ops->get_resv_regions)

dev_iommu_ops warns on a NULL ops, so we either don'tneed the ops check
here or have another problem.

Same in a few more spots.