Re: [PATCH v2 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain

Lu Baolu
2022-02-10T01:20:58Z

On 2/9/22 9:31 PM, Jason Gunthorpe wrote:
> On Tue, Feb 08, 2022 at 09:25:55AM +0800, Lu Baolu wrote:
>> The supported page sizes of an iommu_domain are saved in the pgsize_bitmap
>> field. Retrieve the value from the right place.
>>
>> Signed-off-by: Lu Baolu<baolu.lu@linux.intel.com>
>> Reviewed-by: Robin Murphy<robin.murphy@arm.com>
>> Link:https://lore.kernel.org/r/20211218074546.1772553-1-baolu.lu@linux.intel.com
>> Reviewed-by: Christoph Hellwig<hch@lst.de>
>> ---
>> drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> IMHO it is weird that the ops have a pgsize_bitmap at all.

Agreed. Christoph doesn't like it either. The domain->pgsize_bitmap
should be initialized during domain_alloc(). We plan to make this happen
in or after domain_alloc() refactoring.

Best regards,
baolu