From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C157C433EF for ; Wed, 9 Feb 2022 11:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231629AbiBIL5X (ORCPT ); Wed, 9 Feb 2022 06:57:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231650AbiBILzv (ORCPT ); Wed, 9 Feb 2022 06:55:51 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 793D0E00FA7A for ; Wed, 9 Feb 2022 02:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644404181; x=1675940181; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZzXvGDpuBIFPUCI015ca9co1l1JLyg3bO61AflE667Q=; b=WLoYcHIfjaJ/Wmflq0gu+lbvVYVFLHutpnvAo7C26ve2nJF6FaAwmsYk Yy/wuritJX/28y+VHl2k5JE7V0H87NRIsRH9rZsgEW4nQ3+YlWfDp8dFO 91G03ifDuBBvGbVSSD2UktZkZtmnH2WZqGxNXzOdsIk74OMuoOM19Hj6B NpaMU3hxT7rRyNwDT9oKfOw0ag02cDFJGl1be/oEYsMEpbroDP82A3onF bZuJRQ+E7O1kif6RCbmo7+LcJjJnrN/DKjlCfEOSpEKoFkkL3vfoazYzZ 9q8gf4z2sKxIGySv9simigmuZca1NVbNMLExWoKg4aOl0V4Jxb4ECjYvR g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="236584968" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="236584968" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 02:56:21 -0800 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="485198181" Received: from ravicha1-mobl.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.255.88.114]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 02:56:15 -0800 Date: Wed, 9 Feb 2022 23:56:13 +1300 From: Kai Huang To: "Kirill A. Shutemov" Cc: , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCHv2 00/29] TDX Guest: TDX core support Message-Id: <20220209235613.652f5720cd196331d7a220ec@intel.com> In-Reply-To: <20220124150215.36893-1-kirill.shutemov@linux.intel.com> References: <20220124150215.36893-1-kirill.shutemov@linux.intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > 60 files changed, 2079 insertions(+), 142 deletions(-) > create mode 100644 Documentation/x86/tdx.rst > create mode 100644 arch/x86/boot/compressed/tdcall.S > create mode 100644 arch/x86/boot/compressed/tdx.c > create mode 100644 arch/x86/boot/compressed/tdx.h > create mode 100644 arch/x86/boot/io.h > create mode 100644 arch/x86/include/asm/shared/io.h > create mode 100644 arch/x86/include/asm/shared/tdx.h > create mode 100644 arch/x86/include/asm/tdx.h > create mode 100644 arch/x86/kernel/tdcall.S > create mode 100644 arch/x86/kernel/tdx.c > Hi, Is it better to change the file name(s) to reflect they are for TDX guest support, for instance, especially the last one arch/x86/kernel/tdx.c? TDX host support basically does detection of SEAM, TDX KeyIDs, P-SEAMLDR and initialize the TDX module, so likely TDX host support will introduce couple of new files to do above things respectively, and the majority of the code could be self-contained under some directory (currently under arch/x86/kernel/cpu/tdx/, but can be changed of course). Could we have some suggestions on how to organize? Thanks, -Kai