From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC2AC433EF for ; Thu, 10 Feb 2022 23:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345877AbiBJXss (ORCPT ); Thu, 10 Feb 2022 18:48:48 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244555AbiBJXsr (ORCPT ); Thu, 10 Feb 2022 18:48:47 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4AE75F80 for ; Thu, 10 Feb 2022 15:48:46 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id w20so3225138plq.12 for ; Thu, 10 Feb 2022 15:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+VigcQLytz0iuHCE+k+y78JnvvZ09aQp4DOS6f0o7TM=; b=dAh1C5a34PseGXHmaQZfM4wxYL4wwblUd5jDt5LLve2vU6jWUhtwN8MKnJNOf2qufB lLDHDA3elq1Y16fxoyykEwvdijWHwc7OFoKWI14jMZpOT3WpuvHCKRIZu2l8t+rAqmsE SJZTBCTMhb6eQRwZsHqdo4hY7alEqRycNqGHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+VigcQLytz0iuHCE+k+y78JnvvZ09aQp4DOS6f0o7TM=; b=Y1xdn4DVxN/OJsq3AYasJMq7apVgjNE7Jvt4uf556QjtviwFPrG7PYvT3v9fjmV586 m5u3IezsLV3hRw5t61nMR6rP9Cl/xFolLWRevrXk1u8jnyHuomFzLUn83+Hvd/mrhDLS jAfQevLfQXbs4KY1jljmGayXsZ9XZwE3v3dCdouwzN5Wn223gjJDm2NWNeQQlkwLJlKd 9UnxpdAwzMJpEm7CXWudGE9U1Hfg5tgL5S/miypMyZqrqsz+fj5FILk8FeHvoMoM9Kle EciRGtitRGsnhge37W+KKx17AduFH9JnfCkdLlAnN6Byjmh9pVPl3FSDXXo2NPWltGHa J4rA== X-Gm-Message-State: AOAM5301RBNFC4YnVou4LKAu9anSFzysWveH24XfAGaT//WqPhXC/B0Q GA3B+kl4qwhpX4qEnKDYlRwZ5A== X-Google-Smtp-Source: ABdhPJw7Z7RtNFIjE/eg4qhNf5ROtPlhZI8Yn8t9OlJNY4TOQUQQi24WczGyaruM7kFjyOrv2RoZFw== X-Received: by 2002:a17:902:ef49:: with SMTP id e9mr9590070plx.56.1644536926217; Thu, 10 Feb 2022 15:48:46 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j3sm18279269pgs.0.2022.02.10.15.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 15:48:45 -0800 (PST) Date: Thu, 10 Feb 2022 15:48:44 -0800 From: Kees Cook To: Victor Erminpour Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH] rtc: pcf8523: Fix GCC 12 warning Message-ID: <202202101548.D2CF8DAC@keescook> References: <1644453027-886-1-git-send-email-victor.erminpour@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644453027-886-1-git-send-email-victor.erminpour@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 09, 2022 at 04:30:27PM -0800, Victor Erminpour wrote: > When building with automatic stack variable initialization, GCC 12 > complains about variables defined outside of switch case statements. > Move variables outside the switch, which silences warnings: > > ./drivers/rtc/rtc-pcf8523.c:284:20: error: statement will never be executed [-Werror=switch-unreachable] > 284 | u8 mode; > | > > ./drivers/rtc/rtc-pcf8523.c:245:21: error: statement will never be executed [-Werror=switch-unreachable] > 245 | u32 value; > | ^~~~~ > > Signed-off-by: Victor Erminpour Thanks for finding these! I haven't done any cross compiles with GCC 12 yet. :) Reviewed-by: Kees Cook -- Kees Cook