From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB76C433EF for ; Thu, 10 Feb 2022 23:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345944AbiBJXzv (ORCPT ); Thu, 10 Feb 2022 18:55:51 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345909AbiBJXzu (ORCPT ); Thu, 10 Feb 2022 18:55:50 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6355B5F88 for ; Thu, 10 Feb 2022 15:55:50 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id r64-20020a17090a43c600b001b8854e682eso7229218pjg.0 for ; Thu, 10 Feb 2022 15:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dlMqHYWmeFE9YutBKgR2EWRsK4ahNPNhY+dEU62idVs=; b=U+LPgDEPgoz09gCSOxee5fvC3VuxGKKndS6TlMMy9IQ7jRkw/xAxF6fQZK8UTkyltx whl7YNhPbjG1RVFkAnQIoF917YJGVWExCqY1t5u0AMOKku8nMOHB9T13oQDjrvqzFJ1X eIAzDSm9n97m5x8oa/2fIfW9UEeHpZSiv0G5Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dlMqHYWmeFE9YutBKgR2EWRsK4ahNPNhY+dEU62idVs=; b=WZWB98lMuiG4aSbQkHD4rOIuwebCom8/+7k5VoxtSG4zZ7uGiPG5C+LYmcqYnQY4Bh tkjlVN5kCwHJJilS1Ltt2Pr3jVJbLQToRI62IjgoNaaF1NuYeCR9rQQ80mNsRSd5HKZK 5FAUWH5wOyU3Cgv5TAOaqOl3x31jKRdnbPSFe5i9eF49KwFBc0A2wLSs1dtE1RK8DrMl wtfDhj6ghGhPWhzfDxsjJQe/e8ZN4Btu9iDmBYqf4pw0cwlKvvCPBGaPorZzw38JsxhN 6U3v9qDGL3apUJV1wxTTReEBIcTULnioxSsB5k8bU5qvkZh3xWtpdXjhZnZqcoSJitTt Sf9Q== X-Gm-Message-State: AOAM533MLMEHJoQ745wkqjVsYldHYLMxipJVowrWrXcO0eSp7inoqlPN AKD9rgkz917I/gBtOrdfFSLIKQ== X-Google-Smtp-Source: ABdhPJwWbQAdWi1tu+pJMuOU18Jq/YySWVk/7i1eFjfDT/ZHvGMexKGSOXjumML3yxu4jQLNtqBEZQ== X-Received: by 2002:a17:90b:4f41:: with SMTP id pj1mr5347261pjb.209.1644537349836; Thu, 10 Feb 2022 15:55:49 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j4sm25018194pfc.217.2022.02.10.15.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 15:55:49 -0800 (PST) Date: Thu, 10 Feb 2022 15:55:48 -0800 From: Kees Cook To: Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , kernel@collabora.com, kernelci@groups.io, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] selftests/exec: Rename file binfmt_script to binfmt_script.py Message-ID: <202202101555.EE737A35@keescook> References: <20220210222319.1864680-1-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220210222319.1864680-1-usama.anjum@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 11, 2022 at 03:23:19AM +0500, Muhammad Usama Anjum wrote: > Rename file for readability purpose. Update its usage and references. > > Signed-off-by: Muhammad Usama Anjum > --- > This path was suggested while review of the following patch. Please > apply it after applying that one first: > selftests/exec: Add non-regular to TEST_GEN_PROGS > Changes in V2: > Remove changes from binfmt_script.py, they were wrong Thanks! :) Reviewed-by: Kees Cook -Kees > --- > tools/testing/selftests/exec/Makefile | 2 +- > .../testing/selftests/exec/{binfmt_script => binfmt_script.py} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename tools/testing/selftests/exec/{binfmt_script => binfmt_script.py} (100%) > > diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile > index a89ba6de79870..a0b8688b08369 100644 > --- a/tools/testing/selftests/exec/Makefile > +++ b/tools/testing/selftests/exec/Makefile > @@ -3,7 +3,7 @@ CFLAGS = -Wall > CFLAGS += -Wno-nonnull > CFLAGS += -D_GNU_SOURCE > > -TEST_PROGS := binfmt_script > +TEST_PROGS := binfmt_script.py > TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 non-regular > TEST_GEN_FILES := execveat.symlink execveat.denatured script subdir > # Makefile is a run-time dependency, since it's accessed by the execveat test > diff --git a/tools/testing/selftests/exec/binfmt_script b/tools/testing/selftests/exec/binfmt_script.py > similarity index 100% > rename from tools/testing/selftests/exec/binfmt_script > rename to tools/testing/selftests/exec/binfmt_script.py > -- > 2.30.2 > -- Kees Cook