From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E570EC433EF for ; Fri, 11 Feb 2022 00:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346553AbiBKAwH (ORCPT ); Thu, 10 Feb 2022 19:52:07 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346528AbiBKAwC (ORCPT ); Thu, 10 Feb 2022 19:52:02 -0500 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3D5C5F8E for ; Thu, 10 Feb 2022 16:52:01 -0800 (PST) Received: by mail-pl1-x634.google.com with SMTP id w1so3340295plb.6 for ; Thu, 10 Feb 2022 16:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D3EjEoLgjS5BYa16RZ5JcaZGfnj2NCy9e6R/DsxWvD0=; b=mYDb9T7V8vVpb4vvbK6zkA0h1yevImaISwFUxjrIIoz62k/wF/zDHu5zFn6qzE7kUp 87hdaz0kZHUo4I24hP9Ypim/bw0UCqkm9B/sqsnXEiXBwa22hYfKiyLvWUhlNNdLK62v jkpZSMR3Qi6h9sWFPRK7ScuIfziA7yI6AE748= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D3EjEoLgjS5BYa16RZ5JcaZGfnj2NCy9e6R/DsxWvD0=; b=EyIPLICJS6gEmX+HwuQZyG05iFXUKnzMClHmxTqUmMdMM1NLGrNLklpFXajYr2Rw6q 7X1a0VGISQxbXyauwRByKMyrYMc5HWWTfVwEU1XMr4GYN0h/jalbbme/wD8scorSuaVK owebN57rYantjEXlqdPsMFsVZ3E/LjxS3XizD2BvzgYRH0SZ0jN/MmzRzbrwKTGGdV4R GbbqUD8I9seU1y9+FLpksyMBEzL2507d3RA1dJjj5Ys6qL9hoBqKonoIjGAWG+t2eX18 OrTfTWUKA6VUYhS8/GwMfk4XBl8D9JOKA65bybFae+c5GMrU+GPeV04aor7yELLoI2Q7 ZP9A== X-Gm-Message-State: AOAM530d1whSipoMOkB97MnlEq+cO+gK5JbZdkiCBOeiGq8qdkXhCHZD Fa8FKn0k4HP9toTQukeTvMQoGQ== X-Google-Smtp-Source: ABdhPJw/vLSGOWe5ccZEegSZ0CyTgYC43nd3Y1R3YkYl+lBMWAImTOS4id0LQup7bw2RNv5XlqIpWQ== X-Received: by 2002:a17:90a:5206:: with SMTP id v6mr71812pjh.220.1644540721159; Thu, 10 Feb 2022 16:52:01 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z22sm24478493pfe.42.2022.02.10.16.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 16:52:00 -0800 (PST) Date: Thu, 10 Feb 2022 16:51:59 -0800 From: Kees Cook To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 01/12] powerpc: Move and rename func_descr_t Message-ID: <202202101651.E6AACB3D4F@keescook> References: <637a9a11263afa216fdfa7fb470a54479c67c61c.1634457599.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <637a9a11263afa216fdfa7fb470a54479c67c61c.1634457599.git.christophe.leroy@csgroup.eu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 17, 2021 at 02:38:14PM +0200, Christophe Leroy wrote: > There are three architectures with function descriptors, try to > have common names for the address they contain in order to > refactor some functions into generic functions later. > > powerpc has 'entry' > ia64 has 'ip' > parisc has 'addr' > > Vote for 'addr' and update 'func_descr_t' accordingly. > > Move it in asm/elf.h to have it at the same place on all > three architectures, remove the typedef which hides its real > type, and change it to a smoother name 'struct func_desc'. > > Signed-off-by: Christophe Leroy I like the name. :) Reviewed-by: Kees Cook -- Kees Cook