* [PATCH -next] i2c: designware: remove unneeded semicolon
@ 2022-02-14 1:03 Yang Li
2022-02-14 8:07 ` Jan Dąbroś
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-02-14 1:03 UTC (permalink / raw)
To: jarkko.nikula
Cc: andriy.shevchenko, mika.westerberg, jsd, linux-i2c, linux-kernel,
Yang Li, Abaci Robot
Eliminate the following coccicheck warning:
./drivers/i2c/busses/i2c-designware-amdpsp.c:248:2-3: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/i2c/busses/i2c-designware-amdpsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
index 752e0024db03..f589d3a1a19e 100644
--- a/drivers/i2c/busses/i2c-designware-amdpsp.c
+++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
@@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
if (psp_i2c_access_count) {
psp_i2c_access_count++;
goto cleanup;
- };
+ }
status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
if (status) {
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] i2c: designware: remove unneeded semicolon
2022-02-14 1:03 [PATCH -next] i2c: designware: remove unneeded semicolon Yang Li
@ 2022-02-14 8:07 ` Jan Dąbroś
0 siblings, 0 replies; 2+ messages in thread
From: Jan Dąbroś @ 2022-02-14 8:07 UTC (permalink / raw)
To: Yang Li
Cc: Jarkko Nikula, Andy Shevchenko, Mika Westerberg, linux-i2c,
Linux Kernel Mailing List, Abaci Robot
pon., 14 lut 2022 o 02:03 Yang Li <yang.lee@linux.alibaba.com> napisał(a):
>
> Eliminate the following coccicheck warning:
> ./drivers/i2c/busses/i2c-designware-amdpsp.c:248:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/i2c/busses/i2c-designware-amdpsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
> index 752e0024db03..f589d3a1a19e 100644
> --- a/drivers/i2c/busses/i2c-designware-amdpsp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
> @@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
> if (psp_i2c_access_count) {
> psp_i2c_access_count++;
> goto cleanup;
> - };
> + }
Thanks. While fixing this, please do the same for the 'switch' in
check_i2c_req_sts() function above. Isn't your tool reporting this?
Best Regards,
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-14 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-14 1:03 [PATCH -next] i2c: designware: remove unneeded semicolon Yang Li
2022-02-14 8:07 ` Jan Dąbroś
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox