Re: [PATCH v3 09/10] iommu: Use dev_iommu_ops() helper

Lu Baolu
2022-02-15T01:40:47Z

On 2/14/22 9:26 PM, Jason Gunthorpe wrote:
> On Mon, Feb 14, 2022 at 09:55:37AM +0800, Lu Baolu wrote:
>> This converts all the feasible instances of dev->bus->iommu_ops to
>> dev_iommu_ops() in order to make the operation of obtaining iommu_ops
>> from a device consistent. The dev_iommu_ops() warns on NULL ops, so
>> we don't need to keep the confusing ops check.
>>
>> Suggested-by: Robin Murphy<robin.murphy@arm.com>
>> Signed-off-by: Lu Baolu<baolu.lu@linux.intel.com>
>> ---
>> drivers/iommu/iommu.c | 30 ++++++++++++++----------------
>> 1 file changed, 14 insertions(+), 16 deletions(-)
> I thought you were going to squish this into the prior patch?

I will merge this two patches in the next version. I made them separated
in this series just for ease of review.

Best regards,
baolu