From: Jason Gunthorpe <jgg@nvidia.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
Christoph Hellwig <hch@infradead.org>,
Ben Skeggs <bskeggs@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 09/10] iommu: Use dev_iommu_ops() helper
Date: Mon, 14 Feb 2022 09:26:08 -0400 [thread overview]
Message-ID: <20220214132608.GA4160@nvidia.com> (raw)
In-Reply-To: <20220214015538.2828933-10-baolu.lu@linux.intel.com>
On Mon, Feb 14, 2022 at 09:55:37AM +0800, Lu Baolu wrote:
> This converts all the feasible instances of dev->bus->iommu_ops to
> dev_iommu_ops() in order to make the operation of obtaining iommu_ops
> from a device consistent. The dev_iommu_ops() warns on NULL ops, so
> we don't need to keep the confusing ops check.
>
> Suggested-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/iommu/iommu.c | 30 ++++++++++++++----------------
> 1 file changed, 14 insertions(+), 16 deletions(-)
I thought you were going to squish this into the prior patch?
Jason
next prev parent reply other threads:[~2022-02-14 13:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 1:55 [PATCH v3 00/10] iommu cleanup and refactoring Lu Baolu
2022-02-14 1:55 ` [PATCH v3 01/10] iommu/vt-d: Remove guest pasid related callbacks Lu Baolu
2022-02-14 1:55 ` [PATCH v3 02/10] iommu: Remove guest pasid related interfaces and definitions Lu Baolu
2022-02-14 1:55 ` [PATCH v3 03/10] iommu/vt-d: Remove aux-domain related callbacks Lu Baolu
2022-02-14 1:55 ` [PATCH v3 04/10] iommu: Remove aux-domain related interfaces and iommu_ops Lu Baolu
2022-02-14 1:55 ` [PATCH v3 05/10] iommu: Remove apply_resv_region Lu Baolu
2022-02-14 1:55 ` [PATCH v3 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain Lu Baolu
2022-02-14 12:52 ` Joerg Roedel
2022-02-15 2:08 ` Lu Baolu
2022-02-14 1:55 ` [PATCH v3 07/10] iommu: Use right way to retrieve iommu_ops Lu Baolu
2022-02-14 12:49 ` Joerg Roedel
2022-02-15 1:46 ` Lu Baolu
2022-02-15 2:01 ` Lu Baolu
2022-02-14 1:55 ` [PATCH v3 08/10] iommu: Remove unused argument in is_attach_deferred Lu Baolu
2022-02-14 1:55 ` [PATCH v3 09/10] iommu: Use dev_iommu_ops() helper Lu Baolu
2022-02-14 13:26 ` Jason Gunthorpe [this message]
2022-02-15 1:39 ` Lu Baolu
2022-02-14 1:55 ` [PATCH v3 10/10] iommu: Split struct iommu_ops Lu Baolu
2022-02-14 14:14 ` [PATCH v3 00/10] iommu cleanup and refactoring Joerg Roedel
2022-02-15 2:05 ` Lu Baolu
2022-02-15 9:17 ` Joerg Roedel
2022-02-16 2:56 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214132608.GA4160@nvidia.com \
--to=jgg@nvidia.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=eric.auger@redhat.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox