From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1678C433F5 for ; Tue, 15 Feb 2022 01:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233065AbiBOBkl (ORCPT ); Mon, 14 Feb 2022 20:40:41 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbiBOBkk (ORCPT ); Mon, 14 Feb 2022 20:40:40 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C04F312D204; Mon, 14 Feb 2022 17:40:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644889230; x=1676425230; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=G3WniNW3qk38VLSGBcvoUT5eZOo/115lQFpvE9DOLoA=; b=FosqmIwQjTbMgxrfJTM31Z5lweDV8LHZW/+dtqXIGmbdO1IwSM0ogSK5 +g17unJjg3ZbCRftR0zieD0dtcGaIMMGj8TGLVJldGD46Tmbc6RkEKeys hXEBb2nHY0SbbFF7mqDAvhGuwkTqFrUXBWno0TrAGO7Vq+Pk+OVlzxJPK CAOX+W41k59oAPU3FvWNsXvbVS6OP0AFa3g/ANqYeLQeSBHCPpx9zMWzi SvKgBUXN2JBTKQQhDhQ53PZJO+81rJ+omZXpIRJP0jxXOUVHzE7CEoOQV FPsI7VQ+F5AJ72F15kZxpCa93889yc49Z8GzcTWYp37Dqf+hU+0X4xSPu g==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="230862684" X-IronPort-AV: E=Sophos;i="5.88,369,1635231600"; d="scan'208";a="230862684" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 17:40:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,369,1635231600"; d="scan'208";a="624534774" Received: from lkp-server01.sh.intel.com (HELO d95dc2dabeb1) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 14 Feb 2022 17:40:28 -0800 Received: from kbuild by d95dc2dabeb1 with local (Exim 4.92) (envelope-from ) id 1nJmpP-00099B-Gd; Tue, 15 Feb 2022 01:40:27 +0000 Date: Tue, 15 Feb 2022 09:40:14 +0800 From: kernel test robot To: Andy Shevchenko , Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Jiri Slaby , Javier Martinez Canillas , Geert Uytterhoeven , Andy Shevchenko Subject: Re: [PATCH v1 2/2] serial: sh-sci: Switch to use dev_err_probe_ptr() Message-ID: <202202150928.sqyjprfB-lkp@intel.com> References: <20220214143248.502-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220214143248.502-2-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on usb/usb-testing linux/master linus/master v5.17-rc4 next-20220214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/driver-core-add-a-wrapper-to-device-probe-log-helper-to-return-pointer/20220214-223425 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220215/202202150928.sqyjprfB-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/810910d324cc80b092207d043651de696d293cbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/driver-core-add-a-wrapper-to-device-probe-log-helper-to-return-pointer/20220214-223425 git checkout 810910d324cc80b092207d043651de696d293cbd # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/tty/serial/sh-sci.c: In function 'sci_parse_dt': >> drivers/tty/serial/sh-sci.c:3205:24: error: too few arguments to function 'dev_err_probe_ptr' 3205 | return dev_err_probe_ptr(&pdev->dev, PTR_ERR(rstc), "failed to get reset ctrl\n"); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/node.h:18, from include/linux/cpu.h:17, from include/linux/cpufreq.h:12, from drivers/tty/serial/sh-sci.c:23: include/linux/device.h:988:7: note: declared here 988 | void *dev_err_probe_ptr(const struct device *dev, int err, const char *fmt, va_list args) | ^~~~~~~~~~~~~~~~~ vim +/dev_err_probe_ptr +3205 drivers/tty/serial/sh-sci.c 3187 3188 static struct plat_sci_port *sci_parse_dt(struct platform_device *pdev, 3189 unsigned int *dev_id) 3190 { 3191 struct device_node *np = pdev->dev.of_node; 3192 struct reset_control *rstc; 3193 struct plat_sci_port *p; 3194 struct sci_port *sp; 3195 const void *data; 3196 int id, ret; 3197 3198 if (!IS_ENABLED(CONFIG_OF) || !np) 3199 return ERR_PTR(-EINVAL); 3200 3201 data = of_device_get_match_data(&pdev->dev); 3202 3203 rstc = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); 3204 if (IS_ERR(rstc)) > 3205 return dev_err_probe_ptr(&pdev->dev, PTR_ERR(rstc), "failed to get reset ctrl\n"); 3206 3207 ret = reset_control_deassert(rstc); 3208 if (ret) { 3209 dev_err(&pdev->dev, "failed to deassert reset %d\n", ret); 3210 return ERR_PTR(ret); 3211 } 3212 3213 ret = devm_add_action_or_reset(&pdev->dev, sci_reset_control_assert, rstc); 3214 if (ret) { 3215 dev_err(&pdev->dev, "failed to register assert devm action, %d\n", 3216 ret); 3217 return ERR_PTR(ret); 3218 } 3219 3220 p = devm_kzalloc(&pdev->dev, sizeof(struct plat_sci_port), GFP_KERNEL); 3221 if (!p) 3222 return ERR_PTR(-ENOMEM); 3223 3224 /* Get the line number from the aliases node. */ 3225 id = of_alias_get_id(np, "serial"); 3226 if (id < 0 && ~sci_ports_in_use) 3227 id = ffz(sci_ports_in_use); 3228 if (id < 0) { 3229 dev_err(&pdev->dev, "failed to get alias id (%d)\n", id); 3230 return ERR_PTR(-EINVAL); 3231 } 3232 if (id >= ARRAY_SIZE(sci_ports)) { 3233 dev_err(&pdev->dev, "serial%d out of range\n", id); 3234 return ERR_PTR(-EINVAL); 3235 } 3236 3237 sp = &sci_ports[id]; 3238 *dev_id = id; 3239 3240 p->type = SCI_OF_TYPE(data); 3241 p->regtype = SCI_OF_REGTYPE(data); 3242 3243 sp->has_rtscts = of_property_read_bool(np, "uart-has-rtscts"); 3244 3245 return p; 3246 } 3247 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org