From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346A7C4321E for ; Tue, 15 Feb 2022 15:37:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239335AbiBOPhz (ORCPT ); Tue, 15 Feb 2022 10:37:55 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240636AbiBOPf2 (ORCPT ); Tue, 15 Feb 2022 10:35:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E466C117C; Tue, 15 Feb 2022 07:31:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D6478B8185B; Tue, 15 Feb 2022 15:31:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A6A1C340EB; Tue, 15 Feb 2022 15:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644939067; bh=0qosWklo7YAkGYZCSZxwfWdSMTmaGodxjewobnnr6+A=; h=From:To:Cc:Subject:Date:From; b=NfgECoWSNSXVSFhw+lZys/CXlPtEbd9s4mkqEQiDsPy3BDWxjdjSQmmCsx5HZhf4S 0DEw+xsBqzSKoAhklxwOaDqB0+wS/J3hywT9OrZu1EVbPd6I5/BlRfArLVTi3/ZJiN KwRA9bQd8tcIxUx5X8SqxJPd9twLF0nSg/zbUN2Fb0vnk1xcz9QTSA4p5Dl9OIm8kF r88+M7xjesUjLzwB1OS8ZcF9nTaQ/lVm3LmIQcUkWIJ4H8tBs5fqYt01TVt3nae+nd k346xhb269XTBKgA/DlzFznHZQrDaS70DI+XkPL161lP6OW5I4fmgFaWs5m7TDEUfB 6C3fz9G9v6iTw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wan Jiabing , Tony Lindgren , Sasha Levin , bcousson@baylibre.com, paul@pwsan.com, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 01/11] ARM: OMAP2+: hwmod: Add of_node_put() before break Date: Tue, 15 Feb 2022 10:30:54 -0500 Message-Id: <20220215153104.581786-1-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wan Jiabing [ Upstream commit 80c469a0a03763f814715f3d12b6f3964c7423e8 ] Fix following coccicheck warning: ./arch/arm/mach-omap2/omap_hwmod.c:753:1-23: WARNING: Function for_each_matching_node should have of_node_put() before break Early exits from for_each_matching_node should decrement the node reference counter. Signed-off-by: Wan Jiabing Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/omap_hwmod.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index a8269f0a87ced..47c55351df033 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -754,8 +754,10 @@ static int __init _init_clkctrl_providers(void) for_each_matching_node(np, ti_clkctrl_match_table) { ret = _setup_clkctrl_provider(np); - if (ret) + if (ret) { + of_node_put(np); break; + } } return ret; -- 2.34.1