Re: [PATCH 4/8] drm/client: Use actual bpp when allocating frame buffers

Thomas Zimmermann
2022-02-17T14:58:48Z

[-- Attachment #1.1: Type: text/plain, Size: 1699 bytes --]

Am 15.02.22 um 17:52 schrieb Geert Uytterhoeven:
> When allocating a frame buffer, the number of bits per pixel needed is
> derived from the deprecated drm_format_info.cpp[] field. While this
> works for formats using less than 8 bits per pixel, it does lead to a
> large overallocation.
>
> Reduce memory consumption by using the actual number of bits per pixel
> instead.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
> drivers/gpu/drm/drm_client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index ce45e380f4a2028f..c6a279e3de95591a 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -264,7 +264,7 @@ drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u
>
> dumb_args.width = width;
> dumb_args.height = height;
> - dumb_args.bpp = info->cpp[0] * 8;
> + dumb_args.bpp = drm_format_info_bpp(info, 0);
> ret = drm_mode_create_dumb(dev, &dumb_args, client->file);
> if (ret)
> goto err_delete;
> @@ -372,7 +372,7 @@ static int drm_client_buffer_addfb(struct drm_client_buffer *buffer,
> int ret;
>
> info = drm_format_info(format);
> - fb_req.bpp = info->cpp[0] * 8;
> + fb_req.bpp = drm_format_info_bpp(info, 0);
> fb_req.depth = info->depth;
> fb_req.width = width;
> fb_req.height = height;

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]