From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Phillip Potter <phil@philpotter.co.uk>,
gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
straube.linux@gmail.com, martin@kaiser.cx,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/15] staging: r8188eu: remove smaller sets of converted DBG_88E calls
Date: Thu, 17 Feb 2022 17:36:31 +0300 [thread overview]
Message-ID: <20220217143631.GD2407@kadam> (raw)
In-Reply-To: <e187df14-403c-2908-e4f5-8d38d7f63810@gmail.com>
On Wed, Feb 16, 2022 at 12:42:57PM +0300, Pavel Skripkin wrote:
> > @@ -1467,15 +1447,6 @@ static int rtw_check_join_candidate(struct mlme_priv *pmlmepriv
> > updated = true;
> > }
> > if (updated) {
> > - netdev_dbg(adapter->pnetdev,
> > - "[by_bssid:%u][assoc_ssid:%s]new candidate: %s(%pM rssi:%d\n",
> > - pmlmepriv->assoc_by_bssid,
> > - pmlmepriv->assoc_ssid.Ssid,
> > - (*candidate)->network.Ssid.Ssid,
> > - (*candidate)->network.MacAddress,
> > - (int)(*candidate)->network.Rssi);
> > - netdev_dbg(adapter->pnetdev,
> > - "[to_roaming:%u]\n", rtw_to_roaming(adapter));
> > }
>
> drop if
Yeah. If you can drop the whole if statement then let's do that.
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-17 14:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 1:06 [PATCH v2 00/15] staging: r8188eu: Cleanup and removal of DBG_88E macro Phillip Potter
2022-02-16 1:06 ` [PATCH v2 01/15] staging: r8188eu: remove previously converted DBG_88E_LEVEL calls Phillip Potter
2022-02-16 1:06 ` [PATCH v2 02/15] staging: r8188eu: remove smaller sets of converted DBG_88E calls Phillip Potter
2022-02-16 9:42 ` Pavel Skripkin
2022-02-17 14:29 ` Dan Carpenter
2022-02-17 14:36 ` Dan Carpenter [this message]
2022-02-16 1:06 ` [PATCH v2 03/15] staging: r8188eu: remove converted DBG_88E calls from core/rtw_mlme_ext.c Phillip Potter
2022-02-16 9:50 ` Pavel Skripkin
2022-02-16 1:06 ` [PATCH v2 04/15] staging: r8188eu: remove DBG_88E calls from core subdir Phillip Potter
2022-02-16 1:06 ` [PATCH v2 05/15] staging: r8188eu: remove DBG_88E calls from hal subdir Phillip Potter
2022-02-16 21:35 ` kernel test robot
2022-02-16 1:07 ` [PATCH v2 06/15] staging: r8188eu: remove DBG_88E calls from os_dep/ioctl_linux.c Phillip Potter
2022-02-16 1:07 ` [PATCH v2 07/15] staging: r8188eu: remove remaining DBG_88E calls from os_dep subdir Phillip Potter
2022-02-16 1:07 ` [PATCH v2 08/15] staging: r8188eu: remove remaining DBG_88E call from include/usb_ops.h Phillip Potter
2022-02-16 1:07 ` [PATCH v2 09/15] staging: r8188eu: remove all aliased DBG_88E calls Phillip Potter
2022-02-16 1:07 ` [PATCH v2 10/15] staging: r8188eu: remove DBG_88E macro definition Phillip Potter
2022-02-16 1:07 ` [PATCH v2 11/15] staging: r8188eu: remove rtw_debug module parameter Phillip Potter
2022-02-16 1:07 ` [PATCH v2 12/15] staging: r8188eu: fix lines modified by DBG_88E cleanup Phillip Potter
2022-02-16 1:07 ` [PATCH v2 13/15] staging: r8188eu: remove rtw_sctx_chk_waring_status function Phillip Potter
2022-02-16 1:07 ` [PATCH v2 14/15] staging: r8188eu: remove padapter param from aes_decipher function Phillip Potter
2022-02-16 1:07 ` [PATCH v2 15/15] staging: r8188eu: correct long line warnings near prior DBG_88E calls Phillip Potter
2022-02-16 10:01 ` David Laight
2022-02-16 23:45 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217143631.GD2407@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox