From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FBF3C433EF for ; Thu, 17 Feb 2022 20:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343669AbiBQU3f (ORCPT ); Thu, 17 Feb 2022 15:29:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343651AbiBQU3d (ORCPT ); Thu, 17 Feb 2022 15:29:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66485C3302; Thu, 17 Feb 2022 12:29:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E93B561C27; Thu, 17 Feb 2022 20:29:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42BA2C340E8; Thu, 17 Feb 2022 20:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645129755; bh=MBVB/V4HtFGVcnuF8jusIP3cu1MRbIMiN9GJFCtixlg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=TmhzH2I+N4ljfo2SVnhoeFHVVt8QPUMXw8I5hTMQ6OC3gayYY1eqiMPpWxrTcDzTR +gOWQZXu9lNoFJfY4y6T9DNCFr+rQml7/+S5VMw4GA/jgVSdP1lnpuM8MdJ3fNqTkW GzJXbIzSX0R4ISIUeeUIqt4Zk3mX3ln1SNmuinaDKuVNnOdgo+uDegXxccCM74286Z SfEVxM0t+nSJ5QtEmEnzePJUh+JY+v70DDlJkG9HyFVHhJhDxjTligB+immW5z1gsK gx9oqiXXXo3WGmQdVSBxoosIkaP74VIwqWBF4Ipy41nA/1nSc1gcPExgPWb783rntK X402nlvGfuatA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220208124034.414635-28-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-28-wenst@chromium.org> Subject: Re: [PATCH v3 27/31] clk: mediatek: Unregister clks in mtk_clk_simple_probe() error path From: Stephen Boyd Cc: Chen-Yu Tsai , Chun-Jie Chen , AngeloGioacchino Del Regno , Miles Chen , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org To: Chen-Yu Tsai , Matthias Brugger , Michael Turquette Date: Thu, 17 Feb 2022 12:29:13 -0800 User-Agent: alot/0.10 Message-Id: <20220217202915.42BA2C340E8@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Chen-Yu Tsai (2022-02-08 04:40:30) > Until now the mediatek clk driver library did not have any way to > unregister clks, and so all drivers did not do proper cleanup in > their error paths. >=20 > Now that the library does have APIs to unregister clks, use them > in the error path of mtk_clk_simple_probe() to do proper cleanup. >=20 > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno > --- Applied to clk-next