From: Bjorn Helgaas <helgaas@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 1/2] PCI: Add defines for normal and subtractive PCI bridges
Date: Thu, 17 Feb 2022 15:11:34 -0600 [thread overview]
Message-ID: <20220217211134.GA305475@bhelgaas> (raw)
In-Reply-To: <20220214114109.26809-1-pali@kernel.org>
On Mon, Feb 14, 2022 at 12:41:08PM +0100, Pali Rohár wrote:
> Add following two new PCI class codes defines into pci_ids.h include file:
>
> PCI_CLASS_BRIDGE_PCI_NORMAL
> PCI_CLASS_BRIDGE_PCI_SUBTRACTIVE
>
> And use these defines in all kernel code for describing PCI class codes for
> normal and subtractive PCI bridges.
Looks good; is this another case?
drivers/pci/controller/pci-mvebu.c: dev_rev |= (PCI_CLASS_BRIDGE_PCI << 8) << 8;
> static void quirk_sb1250_ht(struct pci_dev *dev)
> {
> - dev->class = PCI_CLASS_BRIDGE_PCI << 8;
> + dev->class = PCI_CLASS_BRIDGE_PCI_NORMAL;
next prev parent reply other threads:[~2022-02-17 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 11:41 [RESEND PATCH v2 1/2] PCI: Add defines for normal and subtractive PCI bridges Pali Rohár
2022-02-14 11:41 ` [RESEND PATCH v2 2/2] PCI: iproc: Set all 24 bits of PCI class code Pali Rohár
2022-02-17 21:11 ` Bjorn Helgaas [this message]
2022-02-17 21:21 ` [RESEND PATCH v2 1/2] PCI: Add defines for normal and subtractive PCI bridges Pali Rohár
2022-02-17 21:32 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217211134.GA305475@bhelgaas \
--to=helgaas@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pali@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox