From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E120CC433FE for ; Fri, 18 Feb 2022 00:54:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230260AbiBRAyX (ORCPT ); Thu, 17 Feb 2022 19:54:23 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:49368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230224AbiBRAyV (ORCPT ); Thu, 17 Feb 2022 19:54:21 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E087EBE6; Thu, 17 Feb 2022 16:54:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 85662B8216F; Fri, 18 Feb 2022 00:54:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22BCCC340E8; Fri, 18 Feb 2022 00:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645145643; bh=kA1MAHUBUfgVI2vNOFXSWLVuF8lmw0953XqNn2JrIPc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CBC4v4EGq+lqPewuzEukMMasEIXysfSLPopPSzz47ZDgaGfHOh3hg/RPfUAAazBlU F1Q55Nm+WGxBS2JM0/ZCCjMHJaAqLAQc/RkrglqKTAI4bDhrwEbHe82S0T/RPhqbMf 3z/drkBAlDBcjowwSTz7Cipnj9dk1190sTLuHHcbFyBeFA2VbgrONkhbDMmTY/N8Mo o1i66HZe55fAMdoABaNwobF8WWFIKAHcJC8bdph5e2VAm+sdPPOIZ8UT1pQ9W+YIev bhKbG18XY8wk4Miehdd4gHkhwDUG4aEUDqZ6TDU5UEmqUtEYQ6d5wYG20+fLSnrqZQ KjUZhlgxM2NTA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220217232408.78932-1-konrad.dybcio@somainline.org> References: <20220217232408.78932-1-konrad.dybcio@somainline.org> Subject: Re: [PATCH v2] clk: qcom: gcc-msm8994: Remove NoC clocks From: Stephen Boyd Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Konrad Dybcio , Andy Gross , Bjorn Andersson , Michael Turquette , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht Date: Thu, 17 Feb 2022 16:54:01 -0800 User-Agent: alot/0.10 Message-Id: <20220218005403.22BCCC340E8@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Konrad Dybcio (2022-02-17 15:24:08) > Just like in commit 05cf3ec00d460b50088d421fb878a0f83f57e262 > ("clk: qcom: gcc-msm8996: Drop (again) gcc_aggre1_pnoc_ahb_clk") > adding NoC clocks turned out to be a huge mistake, as they cause a lot of > issues at little benefit (basically letting Linux know about their > children's frequencies), especially when mishandled or misconfigured. >=20 > Adding these ones broke SDCC approx 99 out of 100 times, but that somehow > went unnoticed. To prevent further issues like this one, remove them. >=20 > This commit is effectively a revert of 74a33fac3aab77558ca0d80c9935 > (clk: qcom: gcc-msm8994: Add missing NoC clocks) with ABI preservation. >=20 > Fixes: 74a33fac3aab ("clk: qcom: gcc-msm8994: Add missing NoC clocks") > Signed-off-by: Konrad Dybcio > --- Applied to clk-fixes