From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] staging: r8188eu: comment about the chip's packet format
Date: Fri, 18 Feb 2022 13:22:27 +0300 [thread overview]
Message-ID: <20220218102227.GE2407@kadam> (raw)
In-Reply-To: <20220218092252.853807-1-martin@kaiser.cx>
On Fri, Feb 18, 2022 at 10:22:53AM +0100, Martin Kaiser wrote:
> The structs phy_rx_agc_info and phy_status_rpt define parts of the
> header data that the r8188eu chipset sends to this driver via usb.
>
> Add a comment to clarify that we cannot modify the content of these
> structures and remove seemingly unused fields.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>
> Dear all,
>
> I experimented with "cleaning up" these structures and related code before
> discovering that their content comes from usb packets we receive from the
> r8188eu chipset.
>
> Would it make sense to add a word of warning to prevent others from
> repeating this exercise?
Just the fact that these structs are endian means they're from the
firmware or the network.
If a struct has a pointer in it, then it's rarely part of the UAPI but
if it has endian data then it probably is.
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-18 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 9:22 [PATCH RFC] staging: r8188eu: comment about the chip's packet format Martin Kaiser
2022-02-18 10:22 ` Dan Carpenter [this message]
2022-02-18 13:56 ` Martin Kaiser
2022-02-18 17:45 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218102227.GE2407@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox