From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Andy Walls <awalls@md.metrocast.net>,
kernel-janitors@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] media: cx18: use GFP_KERNEL
Date: Fri, 18 Feb 2022 15:26:20 +0300 [thread overview]
Message-ID: <20220218122620.GI2407@kadam> (raw)
In-Reply-To: <20220210204223.104181-3-Julia.Lawall@inria.fr>
On Thu, Feb 10, 2022 at 09:42:16PM +0100, Julia Lawall wrote:
> Pci_driver probe functions aren't called with locks held
> and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.
>
> Problem found with Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> drivers/media/pci/cx18/cx18-driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/cx18/cx18-driver.c b/drivers/media/pci/cx18/cx18-driver.c
> index 59497ba6bf1f..1be9672ae9d4 100644
> --- a/drivers/media/pci/cx18/cx18-driver.c
> +++ b/drivers/media/pci/cx18/cx18-driver.c
> @@ -899,7 +899,7 @@ static int cx18_probe(struct pci_dev *pci_dev,
> return -ENOMEM;
Unrelated to your patch but every error path in this function ought to
call atomic_dec(&cx18_instance);
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-18 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 20:42 [PATCH 0/9] use GFP_KERNEL Julia Lawall
2022-02-10 20:42 ` [PATCH 1/9] net: moxa: " Julia Lawall
2022-02-10 20:42 ` [PATCH 2/9] media: cx18: " Julia Lawall
2022-02-18 12:26 ` Dan Carpenter [this message]
2022-02-10 20:42 ` [PATCH 3/9] ASoC: Intel: bytcr_wm5102: " Julia Lawall
2022-02-11 0:20 ` Pierre-Louis Bossart
2022-02-11 7:43 ` Hans de Goede
2022-02-10 20:42 ` [PATCH 4/9] crypto: " Julia Lawall
2022-02-18 5:37 ` Herbert Xu
2022-02-10 20:42 ` [PATCH 5/9] pata_mpc52xx: " Julia Lawall
2022-02-10 20:45 ` Sergey Shtylyov
2022-02-11 7:43 ` Damien Le Moal
2022-02-10 20:42 ` [PATCH 6/9] media: fsl-viu: " Julia Lawall
2022-02-10 20:42 ` [PATCH 7/9] mtd: spear_smi: " Julia Lawall
2022-02-18 14:32 ` Miquel Raynal
2022-02-10 20:42 ` [PATCH 8/9] [SCSI] mptfusion: " Julia Lawall
2022-02-11 22:10 ` Martin K. Petersen
2022-02-10 20:42 ` [PATCH 9/9] mfd: sta2x11: " Julia Lawall
2022-02-15 13:22 ` Lee Jones
2022-02-12 0:20 ` [PATCH 0/9] " patchwork-bot+netdevbpf
2022-02-14 12:54 ` (subset) " Mark Brown
2022-02-15 3:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218122620.GI2407@kadam \
--to=dan.carpenter@oracle.com \
--cc=Julia.Lawall@inria.fr \
--cc=awalls@md.metrocast.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox