Re: [PATCH 21/22] mmc: wbsd: Use dma_alloc_noncoherent() for dma buffer

Christoph Hellwig
2022-02-22T13:11:32Z

On Tue, Feb 22, 2022 at 05:14:16PM +0800, Baoquan He wrote:
> > No, if you change it, it should be dma_set_coherent_mask only as it is
> > not using streaming mappings. I suspect dma_set_mask_and_coherent is
> > the right thing if the driver ever wants to use streaming mapping,
> > it would just need to be documented in the commit message.
>
> It will serve dma_alloc_noncoherent() calling later, should be streaming
> mapping?

No, that also looks at the coherent mask. Which is a bit misnamed these
days, it really should be the alloc mask.