From: Roger Quadros <rogerq@kernel.org>
To: miquel.raynal@bootlin.com, krzysztof.kozlowski@canonical.com
Cc: vigneshr@ti.com, nm@ti.com, linux@roeck-us.net,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Roger Quadros <rogerq@kernel.org>
Subject: [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error
Date: Sat, 19 Feb 2022 21:36:00 +0200 [thread overview]
Message-ID: <20220219193600.24892-1-rogerq@kernel.org> (raw)
The root of the problem is that we are selecting symbols that have
dependencies. This can cause random configurations that can fail.
The cleanest solution is to avoid using select.
This driver uses interfaces from the OMAP_GPMC driver so we have to
depend on it instead.
Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
drivers/mtd/nand/raw/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 36e697456ec4..9b078e78f3fa 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -42,8 +42,7 @@ config MTD_NAND_OMAP2
tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller"
depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
depends on HAS_IOMEM
- select MEMORY
- select OMAP_GPMC
+ depends on OMAP_GPMC
help
Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4
and Keystone platforms.
--
2.17.1
next reply other threads:[~2022-02-19 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 19:36 Roger Quadros [this message]
2022-02-25 11:15 ` [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2022-02-20 0:44 Guenter Roeck
2022-02-27 6:55 ` Randy Dunlap
2022-03-04 15:54 ` Miquel Raynal
2022-03-04 20:04 ` Guenter Roeck
2022-03-04 22:50 ` Roger Quadros
2022-03-07 10:03 ` Miquel Raynal
2022-03-07 12:25 ` Roger Quadros
2022-03-07 14:12 ` Miquel Raynal
2022-03-07 21:05 ` Roger Quadros
2022-03-08 9:26 ` Miquel Raynal
2022-03-07 14:21 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220219193600.24892-1-rogerq@kernel.org \
--to=rogerq@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=miquel.raynal@bootlin.com \
--cc=nm@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox