From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDFD2C43219 for ; Mon, 21 Feb 2022 10:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353688AbiBUKLV (ORCPT ); Mon, 21 Feb 2022 05:11:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353171AbiBUJ5P (ORCPT ); Mon, 21 Feb 2022 04:57:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13D264615D; Mon, 21 Feb 2022 01:25:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B6A3AB80EC8; Mon, 21 Feb 2022 09:25:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8C45C340E9; Mon, 21 Feb 2022 09:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645435500; bh=Lts16D0Gxmn1OitEUWNDJk37CTFz0Sy/ettipvu2gf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A6zYW9j8O0Gp0E06XAR7CdBPE59TgUZDMfZo2svRCvUrVEfJarz0IjmoMyw5rR3Kr MPhEL8jWV1wEH3OJ/ZZJEYm9eu5iny82YdHGfpbiN5t4hbS1V2Vj/1iS7vzeWtuBlA qJ66sSn7zMvIevJSHJUpMULAyLZGs7XRCw9Bf0SQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, ruckajan10@gmail.com, Ronnie Sahlberg , Steve French Subject: [PATCH 5.16 153/227] smb3: fix snapshot mount option Date: Mon, 21 Feb 2022 09:49:32 +0100 Message-Id: <20220221084939.915559513@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221084934.836145070@linuxfoundation.org> References: <20220221084934.836145070@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French commit 9405b5f8b20c2bfa6523a555279a0379640dc136 upstream. The conversion to the new API broke the snapshot mount option due to 32 vs. 64 bit type mismatch Fixes: 24e0a1eff9e2 ("cifs: switch to new mount api") Cc: stable@vger.kernel.org # 5.11+ Reported-by: Acked-by: Ronnie Sahlberg Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/cifs/fs_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/cifs/fs_context.c +++ b/fs/cifs/fs_context.c @@ -147,7 +147,7 @@ const struct fs_parameter_spec smb3_fs_p fsparam_u32("echo_interval", Opt_echo_interval), fsparam_u32("max_credits", Opt_max_credits), fsparam_u32("handletimeout", Opt_handletimeout), - fsparam_u32("snapshot", Opt_snapshot), + fsparam_u64("snapshot", Opt_snapshot), fsparam_u32("max_channels", Opt_max_channels), /* Mount options which take string value */ @@ -1072,7 +1072,7 @@ static int smb3_fs_context_parse_param(s ctx->echo_interval = result.uint_32; break; case Opt_snapshot: - ctx->snapshot_time = result.uint_32; + ctx->snapshot_time = result.uint_64; break; case Opt_max_credits: if (result.uint_32 < 20 || result.uint_32 > 60000) {