From: Dan Carpenter <dan.carpenter@oracle.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] staging: vt6656: Fix CamelCase, add comments, change macro to function
Date: Tue, 22 Feb 2022 08:26:55 +0300 [thread overview]
Message-ID: <20220222052654.GL3965@kadam> (raw)
In-Reply-To: <cover.1645477326.git.philipp.g.hortmann@gmail.com>
On Mon, Feb 21, 2022 at 10:24:52PM +0100, Philipp Hortmann wrote:
> Various checkpatch.pl fixes as liste below
> Tested with device VNT6656G6A40
> Transferred this patches over VNT6656G6A40
>
> v2: Patch #1
> Changed EN_CFG_PKT_BURST_MO to EN_CFG_PKT_BURST_MD
> Patch #2
> Devided into three patches
> Patch #3
> Devided into two patches
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
The one thing per patch rule is slightly complicated and different
maintainers have slightly different lines that they draw. You could
have merged patches 3 and 4 together and it would have been fine. But
what you sent is also fine.
regards,
dan carpenter
prev parent reply other threads:[~2022-02-22 5:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 21:24 [PATCH v2 0/6] staging: vt6656: Fix CamelCase, add comments, change macro to function Philipp Hortmann
2022-02-21 21:24 ` [PATCH v2 1/6] staging: vt6656: Fix CamelCase warnings in mac.h and mac.c Philipp Hortmann
2022-02-21 21:25 ` [PATCH v2 2/6] staging: vt6656: Add comment for locks Philipp Hortmann
2022-02-21 21:25 ` [PATCH v2 3/6] staging: vt6656: Fix CamelCase warnings in macro Philipp Hortmann
2022-02-21 21:25 ` [PATCH v2 4/6] staging: vt6656: Change macro to function and moved to better file Philipp Hortmann
2022-02-21 21:25 ` [PATCH v2 5/6] staging: vt6656: Remove ftrace-like logging Philipp Hortmann
2022-02-21 21:25 ` [PATCH v2 6/6] staging: vt6656: Remove unnecessary line breaks Philipp Hortmann
2022-02-22 5:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222052654.GL3965@kadam \
--to=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox